Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search and pagination are working but if no results are returned the loading screen doesnt dissapear #102

Closed
noahehall opened this issue Dec 3, 2022 · 0 comments
Closed

search and pagination are working but if no results are returned the loading screen doesnt dissapear #102

noahehall opened this issue Dec 3, 2022 · 0 comments
Assignees
@noahehall

Comments

@noahehall
Copy link
Contributor

noahehall commented Dec 3, 2022 •
edited
Loading

C

  • issue is on every screen that renders a list of things
  • there all set to return not found error screen if no data exists

T

  • create NoResults component for this use case
  • loading screen not dissapearing was due to list of things throwing not found

A

  • for now its a sorry, no results - but find time to style it, and enable customization by consumers
@noahehall noahehall added this to nirvai Dec 3, 2022
@noahehall noahehall converted this from a draft issue Dec 3, 2022
@noahehall noahehall changed the title search + pagination and any therof is working but if nor esults are returned the loading screen doesnt dissapear search and pagination are working but if no results are returned the loading screen doesnt dissapear Dec 3, 2022
Repository owner moved this from FAST lane to DEPLOYED in nirvai Dec 3, 2022
@noahehall noahehall self-assigned this Dec 3, 2022
@noahehall noahehall mentioned this issue Dec 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahehall noahehall

Labels
None yet
Projects
nirvai
Status: DEPLOYED
Milestone
No milestone
Development

No branches or pull requests
1 participant
@noahehall