Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRChat ワールドURLのプレビュー表示を改善 #101

Closed
Sayamame-beans opened this issue Nov 27, 2023 · 11 comments
Closed

VRChat ワールドURLのプレビュー表示を改善 #101

Sayamame-beans opened this issue Nov 27, 2023 · 11 comments
Labels
✨Feature This adds/improves/enhances a feature

Comments

@Sayamame-beans
Copy link

Summary

ぶいちゃのワールドサムネがみすきーでも見えるようになればいいのになあ

https://misskey.niri.la/notes/9knln6o0mp

TwitterでもDiscordでも表示されるな…つまり、:misskey:がプレビューする対象が良くない

https://misskey.niri.la/notes/9knlsesi9i

Purpose

ワールドのサムネは見えた方が良い

時々動画がサムネ?になるケースがあると記憶していて、それはプレイヤーを直接開けた方が嬉しいとかあるのかもしれない(分からない)(こっちは優先度低)

@Sayamame-beans Sayamame-beans added the ✨Feature This adds/improves/enhances a feature label Nov 27, 2023
@Sayamame-beans
Copy link
Author

このissueに取り組む際、特別な対応(VRC固有の対応)を行わなくて良かった場合は本家にもcommit投げた方が良いかもしれない。

@KisaragiEffective
Copy link

例: SuRRoomだと

curl https://vrchat.com/home/world/wrld_beddab1e-fee1-cafe-f00d-ca7c0dd1eca7 \
  -H "User-Agent: KisaragiMarine/1.0; contact: https://github.com/KisaragiEffective"

から

<!-- <head> -->
    <meta name="description" content="SuRroom by citrusxr - a virtual reality world on VRChat">
<meta name="twitter:card" content="summary_large_image">
<meta name="twitter:site" content="VRChat">
<meta name="twitter:title" content="SuRroom by citrusxr">
<meta name="twitter:description" content="Experience true VR home world․ Multilingual supported․ created by ˸ CITRUS Studio members˸["Shatoo"‚ "ureishi"‚ "Rastvas"‚ "Izzy_da"]">
<meta name="twitter:creator" content="VRChat">
<meta name="twitter:image" content="https://api.vrchat.cloud/api/1/file/file_0043cc43-931c-4c4e-87a0-2e0e4622d320/3/file">
<meta name="twitter:image:alt" content="A preview image of VRChat world &quot;SuRroom&quot; by citrusxr">
<meta name="og:title" content="SuRroom by citrusxr">
<meta name="og:type" content="website">
<meta name="og:image" content="https://api.vrchat.cloud/api/1/file/file_0043cc43-931c-4c4e-87a0-2e0e4622d320/3/file">
<meta name="og:image:alt" content="A preview image of VRChat world &quot;SuRroom&quot; by citrusxr">
<meta name="og:description" content="Experience true VR home world․ Multilingual supported․ created by ˸ CITRUS Studio members˸["Shatoo"‚ "ureishi"‚ "Rastvas"‚ "Izzy_da"]">
<meta name="og:siteName" content="VRChat">

が返ってきます

@anatawa12
Copy link
Collaborator

https://misskey.niri.la/notes/9mkabmpwut

流れてきたlinkの最初を取ってる説がありそう。

@anatawa12
Copy link
Collaborator

@anatawa12
Copy link
Collaborator

うーんOGPのmetaタグって<meta property="og:image" content="">が正しいので、VRChatのwebsiteのCanny書くのが正しそう。

https://ogp.me/

@anatawa12
Copy link
Collaborator

しかしsummalyがわもバグってるな。twitter card用の値は<meta name="twitter:image" content="">が正しいようだけどpropertyでとってる

https://developer.twitter.com/en/docs/twitter-for-websites/cards/overview/summary

		$('meta[property="twitter:image"]').attr('content') ||

https://github.com/syuilo/summaly/blob/b994e67281abc3faae53c888a232c84a4ea1a01d/src/general.ts#L30C1-L30C57

@anatawa12
Copy link
Collaborator

とりあえずtwitter card imageの話はissueにした syuilo/summaly#151

@anatawa12
Copy link
Collaborator

misskey-dev/summaly#14

npmにあるのは古いらしいので作り直した

@anatawa12
Copy link
Collaborator

@KisaragiEffective
Copy link

tracked on canny

canny status: tracked

@anatawa12
Copy link
Collaborator

#122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨Feature This adds/improves/enhances a feature
Projects
None yet
Development

No branches or pull requests

3 participants