Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for TransformMap #46

Closed
oesteban opened this issue Oct 31, 2019 · 0 comments · Fixed by #59
Closed

Support for TransformMap #46

oesteban opened this issue Oct 31, 2019 · 0 comments · Fixed by #59

Comments

@oesteban
Copy link
Collaborator

This would be a list of Affines, for instance, to correct for head motion. In this case, the TransformMap.map(x) method (with N transforms in the map) will generate N mappings of x.

The difference with concatenation is that transforms are not sequential in the map, they are applied in parallel.

oesteban added a commit to oesteban/nitransforms that referenced this issue Feb 18, 2020
Implements two types of transforms mappings:

1. a general one for any internal transform, and
2. an optimized mapping for lineart transforms (head-motion correction).

Since scipy's interpn only accepts linear and nearest interpolations,
these mappings will not support for simultaneous slice-timing correction
(STC) for the time being.

The addition of 4D tensor B-Spline basis for interpolation would allow
for simultaneous STC, HMC and SDC of functional time-series.
Not sure we should keep supporting Lanczos interpolation, very much less
if we want to do all three corrections at the same time.

Closes nipy#46
oesteban added a commit to oesteban/nitransforms that referenced this issue Feb 18, 2020
Implements two types of transforms mappings:

1. a general one for any internal transform, and
2. an optimized mapping for lineart transforms (head-motion correction).

Since scipy's interpn only accepts linear and nearest interpolations,
these mappings will not support for simultaneous slice-timing correction
(STC) for the time being.

The addition of 4D tensor B-Spline basis for interpolation would allow
for simultaneous STC, HMC and SDC of functional time-series.
Not sure we should keep supporting Lanczos interpolation, very much less
if we want to do all three corrections at the same time.

Closes nipy#46
oesteban added a commit to oesteban/nitransforms that referenced this issue Feb 19, 2020
Implements two types of transforms mappings:

1. a general one for any internal transform, and
2. an optimized mapping for lineart transforms (head-motion correction).

Since scipy's interpn only accepts linear and nearest interpolations,
these mappings will not support for simultaneous slice-timing correction
(STC) for the time being.

The addition of 4D tensor B-Spline basis for interpolation would allow
for simultaneous STC, HMC and SDC of functional time-series.
Not sure we should keep supporting Lanczos interpolation, very much less
if we want to do all three corrections at the same time.

Closes nipy#46
oesteban added a commit to oesteban/nitransforms that referenced this issue Feb 19, 2020
Implements two types of transforms mappings:

1. a general one for any internal transform, and
2. an optimized mapping for lineart transforms (head-motion correction).

Since scipy's interpn only accepts linear and nearest interpolations,
these mappings will not support for simultaneous slice-timing correction
(STC) for the time being.

The addition of 4D tensor B-Spline basis for interpolation would allow
for simultaneous STC, HMC and SDC of functional time-series.
Not sure we should keep supporting Lanczos interpolation, very much less
if we want to do all three corrections at the same time.

Closes nipy#46
oesteban added a commit to oesteban/nitransforms that referenced this issue Feb 19, 2020
Implements two types of transforms mappings:

1. a general one for any internal transform, and
2. an optimized mapping for lineart transforms (head-motion correction).

Since scipy's interpn only accepts linear and nearest interpolations,
these mappings will not support for simultaneous slice-timing correction
(STC) for the time being.

The addition of 4D tensor B-Spline basis for interpolation would allow
for simultaneous STC, HMC and SDC of functional time-series.
Not sure we should keep supporting Lanczos interpolation, very much less
if we want to do all three corrections at the same time.

Closes nipy#46
oesteban added a commit to oesteban/nitransforms that referenced this issue Feb 20, 2020
Implements two types of transforms mappings:

1. a general one for any internal transform, and
2. an optimized mapping for lineart transforms (head-motion correction).

Since scipy's interpn only accepts linear and nearest interpolations,
these mappings will not support for simultaneous slice-timing correction
(STC) for the time being.

The addition of 4D tensor B-Spline basis for interpolation would allow
for simultaneous STC, HMC and SDC of functional time-series.
Not sure we should keep supporting Lanczos interpolation, very much less
if we want to do all three corrections at the same time.

Closes nipy#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant