Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize runtime threads in gantt chart #3700

Open
effigies opened this issue Nov 18, 2024 · 0 comments
Open

Normalize runtime threads in gantt chart #3700

effigies opened this issue Nov 18, 2024 · 0 comments

Comments

@effigies
Copy link
Member

#3290 restored gantt chart functionality. The PR was generally delayed by a concern that the thread representation is misleading.

The proposed solution is:

if status_dict['runtime_threads'] != "N/A":
    status_dict['runtime_threads'] //= 100

I believe here:

status_dict = {
"name": node.name,
"id": node._id,
"start": node.result.runtime.startTime,
"finish": node.result.runtime.endTime,
"duration": node.result.runtime.duration,
"runtime_threads": getattr(node.result.runtime, "cpu_percent", "N/A"),
"runtime_memory_gb": getattr(node.result.runtime, "mem_peak_gb", "N/A"),
"estimated_memory_gb": node.mem_gb,
"num_threads": node.n_procs,
}
if status_dict["start"] is None or status_dict["finish"] is None:
status_dict["error"] = True

cc @shnizzedy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant