ENH: Provide informative exception if command needs a heuristic to be specified #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #437 +/- ##
==========================================
+ Coverage 74.92% 75.04% +0.12%
==========================================
Files 35 35
Lines 2831 2841 +10
==========================================
+ Hits 2121 2132 +11
+ Misses 710 709 -1
Continue to review full report at Codecov.
|
|
will add a bit more testing |
|
nice and green now, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses last item in #173 - ideally should work without heuristic, but not ATM, so I will keep that issue open, but at least it should crash more informatively