Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF for #344 idea: explicit list/dict of "bids actions" to possibly consider #349

Open
yarikoptic opened this issue May 20, 2019 · 0 comments

Comments

@yarikoptic
Copy link
Member

I had another idea about #344 one, but I guess we could get to it after this PR is merged . If I get to it I will work on top of the #344.

The idea is somewhat a meld between current implementation in #344 and what I recommended originally there.

Idea: define a list (or dict if with description) of known options for BIDS for every BIDS-related step we take (there might be more -- didn't check yet):

bids_options = {
   'dcm2niix-sidecar': "Produce BIDS sidecar files by dcm2niix",
   'extended-metadata': "Extend metadata with more using ....", # deprecates --minmeta
   'toplevel-templates': "Produce templates for README, dataset-description.json, etc",
   'toplevel-taskfiles': "Aggregate common information from task-* files and place those files at the top of the dataset",
}

By default we would enable all ATM (--bids would provide empty list as a sign for that), but in the future we could add some which would not be enabled by default may be (e.g. date-offset?)
And then in --bids options we could add treatment for "noX" to disable (remove) specific ones from the list of enabled. Or later enable additional (no "no" prefix) options.

In the code, we could then just always check for the corresponding feature (if 'dcm2niix-sidecar in bids_options:) instead of doing generic if bids`.

Just an idea for discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant