Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop pre-commit config and hook? #146

Open
oesteban opened this issue Mar 28, 2024 · 2 comments
Open

Drop pre-commit config and hook? #146

oesteban opened this issue Mar 28, 2024 · 2 comments

Comments

@oesteban
Copy link
Member

I am not a fan of pre-commit - do we agree to remove it?

@jhlegarreta
Copy link
Collaborator

Not sure if I see the advantage of dropping it: please, correct me if I'm wrong, but when the non-compliant code is pushed, developers need to wait for the CI job, inspect it, fix any warning locally, then push again, wait for another cycle, inspect again whether there are warnings, etc. generating unnecessary noise. Not the best use of time, including that of the maintainers. In some cases, it may be days/weeks until the contributor addresses those changes, potentially delaying any other development that may depend on those changes. And people tend to add commits like STYLE: Fix PEP8 (this being the most descriptive commit subject) that IMO pollute the history and prevent focusing on relevant changes. All this assumes that people have done pip install -e .[dev] when contributing, which is not that much expensive (time, space) compared to a bare pip install -e .

But it is just an opinion of mine.

@oesteban
Copy link
Member Author

I'm not against the pipeline, I'm concerned about the particular tool (or better, how the project is handled).

I guess I'll change my opinion when pre-commit supports its configuration within pyproject.toml or it is superseded by another project with different leadership.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants