Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws_upgrade doesn't alter keepalive value #220

Open
Gazler opened this issue Mar 2, 2020 · 1 comment
Open

ws_upgrade doesn't alter keepalive value #220

Gazler opened this issue Mar 2, 2020 · 1 comment

Comments

@Gazler
Copy link

Gazler commented Mar 2, 2020

Given the following code snippet:

gun:open(Host, Port, #{})
gun:ws_upgrade(Pid, Url, [], #{keepalive=> infinity})

The keepalive continues to use the default value, and a keepalive is sent after 5 seconds.

The following correctly sets the keepalive value:

gun:open(Host, Port, #{ws_opts => #{keepalive => infinity}})
gun:ws_upgrade(Pid, Url, [], #{})
@essen essen added this to the 2.0 milestone Mar 3, 2022
@essen
Copy link
Member

essen commented Nov 14, 2022

This is linked (conceptually) to handling of keepalive in tunnels. I'll leave it for after 2.0 as it is not a small change.

@essen essen removed this from the 2.0 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants