Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy script, like the one in the Wallet #553

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

mraveux
Copy link
Member

@mraveux mraveux commented Nov 27, 2024

No description provided.

Copy link
Member

@danimoh danimoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion by @hrxi (also applies to the other repositories). Other than that good to go.

#!/bin/bash

# Exit on error
set -e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hrxi says we should do this.
He also says the last line might not work on trash Mac.

Suggested change
set -e
set -eu
set -o pipefail

@danimoh danimoh merged commit 6049963 into master Nov 28, 2024
0 of 2 checks passed
@danimoh danimoh deleted the matheo/add-deploy-script branch November 28, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants