Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addHMC vs. other approaches #6

Open
paciorek opened this issue Jun 16, 2022 · 3 comments
Open

addHMC vs. other approaches #6

paciorek opened this issue Jun 16, 2022 · 3 comments
Assignees
Labels
question Further information is requested

Comments

@paciorek
Copy link
Contributor

  1. @danielturek can we discuss the use of addHMC as a stand-alone function instead of our usual addSampler method?
    Is the idea that we want it to default to sampling all nodes, hence the need for a different function? However, given we have configureHMC which seems to accomplish that purpose, I'm wondering if we need addHMC?
  2. help(nimble_HMC) uses addSampler rather than addHMC. Is that what we want to show?
@paciorek paciorek added the question Further information is requested label Jun 16, 2022
@paciorek
Copy link
Contributor Author

Related question: what do we think is the canonical way to get an HMC sampler - I'm guessing it is either via configureHMC or buildHMC or nimbleHMC?

If so, that may be another argument for modifying the example code for ?sampler_HMC. Or perhaps augmenting to show more of the ways one can get an HMC sampler.

I think use of addSampler with HMC is mainly for cases where users want to mix-and-match samplers, so we may want to hint at this in comments in the example code for sampler_HMC?

@danielturek
Copy link
Member

@perrydv Should be involved in this discussion, as well.

I'm fine with anything. The original inspiration here was to make [the use of] nimbleHMC as easy as possible, hence the addition of a variety of convenience functions to access the HMC sampler.

Cases could be made for or against any of addHMC, configureHMC, or buildHMC.

Tbh I'm somewhat indifferent. You guys may recall I was never originally in favor of nimbleMCMC, but its experienced quite some adoption, so....

@danielturek
Copy link
Member

Note to self: I should add to the @example code for both sampler_NUTS and sampler_NUTS_classic, to also demonstrate use of addHMC, configureHMC, and perhaps also nimbleHMC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants