Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does nimble need to be a dependency? #22

Closed
tbrown122387 opened this issue Nov 4, 2021 · 1 comment
Closed

does nimble need to be a dependency? #22

tbrown122387 opened this issue Nov 4, 2021 · 1 comment

Comments

@tbrown122387
Copy link

tbrown122387 commented Nov 4, 2021

This is more of a question:

What happens if we remove nimble as a dependency? Should it be? If this is a standalone project, it might be desirable to remove it. Also, it looks like there are certain variable names that are shared (e.g. compareMCMCs()), so you'll need to be vigilant about using the :: operator.

R6, nimble, ggplot2, grid, reshape2, xtable

openjournals/joss-reviews#3844

@perrydv
Copy link
Collaborator

perrydv commented Nov 29, 2021

@tbrown122387 I did clean up other entries in Depends vs Imports, but it looks like we do need nimble in Depends. It's related to how nimble does a lot of R code generation and evaluation. For example, it makes on-the-fly function definitions to use in models and class definitions for models and other components. This brings up issues to do with nimble more than compareMCMCs so I won't go further. If possible in the future we will be able to move nimble from Depends to Imports.

The reason for the duplication of the name compareMCMCs across packages is that the idea started as a function in nimble and now is being separated into its own package here (and completely re-designed). So compareMCMCs in nimble just tells users they need this new package. Once this is released, we will eventually remove compareMCMCs from nimble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants