Do not use system.NimVersion for nim.nimble

[yyoncho]

• That version is evaluaed in the context of nim version used by nimble

[metagn]

Maybe from lib/system import NimVersion?

[Araq]

Nimble delegates Nimscript evaluation to Nim so this should be fine.

[yyoncho]

Nimble delegates Nimscript evaluation to Nim so this should be fine.

@Araq indeed. If you do the following

choosenim "#version-1-2"
nimble install

you will end up with the following package in the pkgs2 directory: nim-1.2.19-f49de7c8bd455fb50778683448ac4d9f5fc3e029

and the following output:

...
  target type: 'uint' (8 bytes)
  source type: 'set[ValidationErrorKind]' (1 byte) [CastSizes]
  Verifying dependencies for [email protected]
 Installing [email protected]
  Success:  nim installed successfully.

That will happen no matter what is the Nim version you have checked out.

[Araq]

I don't understand, why is this a problem?

[yyoncho]

I don't understand, why is this a problem?

@Araq, it is a problem when you have something like requires "nim == 1.7.1". Then when nimble tries to install the packages it will fail because the validation of the package will fail because nimble will think that the package it is trying to install is not 1.7.1. That will happen if local nim is not 1.7.1

See nim-lang/nimble#1017 .

[Araq]

We will forget to update nim.nimble though so this solution is pretty bad. Any alternatives possible? How about nim.nimble doesn't specify the version and Nimble uses git tags in order to determine a version? That's what Nimble should have done to begin with, anyway.

[yyoncho]

How about nim.nimble doesn't specify the version and Nimble uses git tags in order to determine a version?

I will check if we can work with that. It is a bit unclear to me what version should I use in case the revision at hand is not tagged.

In general, I can patch nimble to handle nim package as a special case(e. g. go and read that file) but we have to figure out what would work.

[Araq]

You don't have to special case Nim for this, Nimble should accept nimble files lacking version and then use hg/git tags instead.