important_packages: allowed_failures batch
#17757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
timotheecour
force-pushed
the
pr_important_packages_failbatch
branch
from
941b38b to
15038a5
Compare
timotheecour
force-pushed
the
pr_important_packages_failbatch
branch
from
15038a5 to
e3d1a58
Compare
timotheecour
force-pushed
the
pr_important_packages_failbatch
branch
from
e3d1a58 to
0c73a38
Compare
timotheecour
changed the title
allowed_failures batch
Maybe we could use the |
Merged
timotheecour
added
the
TODO: followup needed
PMunch
pushed a commit
to PMunch/Nim
that referenced
this pull request
Mar 28, 2022
* important_packages: reserve batch 0 for allowed failures * custom batch name: allowed_failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follows #17301 and #17513
fixes #17513 (comment)
future work
consider turning CI success into a failure in case 1 of the
allowed_failuresstarts working so we can removeallowed_failure = true(maybe requires distinguishing flaky failures from other failures)