styleCheck: Fix error for sugar and std/with

[ee7]

With this commit, we no longer see an error if we pass
--styleCheck:error when compiling a file that contains import sugar
or import std/with.

The problem was that those modules (and only those modules) import
std/private/underscored_calls, which contained a styleCheck issue:
its spelling of nnkArgList didn't match the nnkArglist spelling in
macros.nim.

This commit fixes the issue by renaming nnkArglist to nnkArgList
repo-wide.

Fixes: #16174

CI failure is unrelated (see #16169).

[ee7]

@xflywind Closing and reopening this PR doesn't help here to make CI green :)

This PR needed to be rebased on devel so that it includes the commit dd5405c.

[Araq]

This is a breaking change though for --styleCheck:error based code. Instead rename nkArgList to nkArglist.

[ee7]

This is a breaking change though for --styleCheck:error based code.

Ok - I've updated this PR so that it does nnkArgList -> nnkArglist repo-wide, including in

Nim/tests/astspec/tastspec.nim

Line 932 in 139075e

of nnkTypeDef(_, _, nnkTypeClassTy(nnkArgList, _, _, nnkStmtList)):

but maybe you'd prefer to leave that one as-is.

Instead rename nkArgList to nkArglist

Did you mean to write nnk, or do you also want nkArgList -> nkArglist?

nnkArgList -> nnkArglist does seem a bit unfortunate, given that we have:

• nnkStmtList
• nnkStmtListExpr
• nnkStmtListType
• nnkRecList
• nkArgList (one n)

I'm okay with the current state of this PR, given that it fixes import sugar with --styleCheck:error.

But is it not possible to switch to nnkArgList in macros.nim, adding a special case to styleCheck so that compiling a file containing nnkArglist with --styleCheck:error produces a deprecation warning, rather than an error?

[Araq]

I meant it in the way you did it.