-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's no $
for openArray
#7940
Comments
that's because $ is not defined for openarray |
$
for openArray
Ah, was just going to comment on that.. here's an even smaller example: proc testOpenArray(x: openArray[int]) =
echo x I am aware that |
From my patched superpupercool system.nim :) proc `$`*[T](x: openarray[T]): string =
## generic ``$`` operator for openarrays that is lifted from the components
## of `x`. Example:
##
## .. code-block:: nim
## $(@[23, 45].toOpenArray(0, 1)) == "[23, 45]"
collectionToString(x, "[", ", ", "]") |
@data-man what do you have in your patched superpupercool system.nim and why you don't make PRs? 💃 |
@data-man Of course I tried it and didn't work.. your superpupercool system.nim has |
@kaushalmodi no, collectionToString is a proc defined in system.nim, but it's not exported. |
@Yardanico Because PRs for system.nim often isn't accepted.
Many Things. :-D |
@data-man well, you should at least try to make a PR, so there will be a discussion and people will decide if it's good to put it in system.nim |
Should try? |
Well, it means that you don't want to contribute to Nim (with system.nim additions) :P |
@data-man I didn't mean that you should just commit, I've meant that you should make PRs, but ok :D |
@Yardanico I hope that Araq wouldn't object to this improvement. ;) |
Compiling that gives this error:
The text was updated successfully, but these errors were encountered: