-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recent regression in generics as demo'd by jason package #16389
Comments
can you try git bisect?
please show git hashes, avoids guess work |
No guess work. Yesterday's nightly worked, today's nightly doesn't. The only significant PR I noticed was Araq's IC patch. |
imagine someone looking at this issue a week or a month from now, assuming this isn't fixed by that time; he'd have to match git log time with the time you submitted your issue and adjust time zone, etc. That's guess work. That's why issues need the github hash (it's even recommended in issue template), it avoids all guess work. |
You're right; it'd be a shame to leave the regression unfixed for a month and have to do all that work. |
Here's a link to the nightly release commit at the time of writing: |
@disruptek what happens if you recompile nim with: this helps narrow down. I've also hit this in another other library. |
I would rather not see another option added to the compiler. It would be better to fix the logic that makes the presumption that |
my point was whether the regression you're observing generates an infinite number of instantiations or an increase in number of instantiations |
So you think we should set an I don't understand the logic here. The point I'm trying to make is that the constant shouldn't even exist. It's a technique @Araq likes to use, but that doesn't mean it's wise. |
That's not my point at all. To debug your issue, I'm asking whether the compiler now tries to generate just a larger nb of instantiations or whether it looks like it attempts to enter an infinite loop (eg as in a stack overflow). |
It's much wiser than runaway recursions in the compiler with its associated stack overflows (bad) or infinite loops (worse!)... |
The irony is that, as regressions go, infinite loops don't live very long. Please fix the bug or revert the change. If the code doesn't work, I don't care if the compiler crashes -- it was never going to serve my needs in any event. There are cheaper ways (I'm looking at you, Gentoo) to heat my home. |
it's not clear from what you wrote whether this is the commit that introduced the regression or not 868c31e |
I use your nightlies. The one prior to that was fine. The one I supplied was not. |
I gave up. |
It passed CI on devel yesterday but today it doesn't. The error points to the
typ = o.getTypeInst
line:... from https://github.com/disruptek/jason which has been rewritten even more simply since, but still demonstrates the error...
The text was updated successfully, but these errors were encountered: