-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Costing Option Display #161
Conversation
Hi, hope you are doing well. |
Thankyou @MuneebAhmed25211 for your suggestions. |
Ok @hs7898753 I have another idea If we distribute the settings into different dropdowns under the settings dropdown e.g. I see there are 3 options of length, width and height in the extra settings options. If we combine these 3 into a single dropdown (e.g. dimensions) in the extra settings menu, it will take less space and will be clean. If we choose the names of the dropdowns properly and will make the pairs properly (like length, width, height). I suppose it will make no confusion according to me. Hope you understand. |
Yah! We can do it. thank you |
Yeah I like that idea! It's true, there's so much space wasted actually. Probably we'll need to even get rid of "General" & "Extra" settings and just provide one settings which is unique for the selected mode. Grouping them like that was mostly due to not repeating code that much. But that really made the code much more confusing and spaghetti, maybe it's better to have the settings for each mode cleanly separated in the code as well at the expense of duplicating the same options a few times. Then it needs a "careful" grouping of costing options which makes sense. The ones you mentioned make sense. There could also be one for e.g. "road classes" which groups Good suggestion, thanks! |
Yah! I agree with the suggestion. |
If there are good icons for what the groups, sure.. I'd say one after the other, and first have a good outline of the grouping If we go that way, it's a bigger job and more suitable for the GSoC project, rather than now. It fits into the whole re-write we plan to do. I'll transfer the idea to the appropriate issue. |
π οΈ Fixes Issue
Closes #147
π¨βπ» Changes proposed
I suggest showing only the general settings by default and moving the extra settings into a dropdown menu. This will allow users to easily access the settings they need, without being overwhelmed by too much information at once.
π Note to reviewers
π· Screenshots
Untitled.1.mp4