-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid having Webpack load the UMD module #42
Conversation
The CI is due to missing env variables for Browserstack. I suspect this is failing because it's a PR from a fork. |
I can see your point, but I would like to leave |
@niksy Obviously this is your call but I'd be curios why? AFAIK there's no advantage to delivering UMD builds to bundlers which are the main consumer of the I think that's very undesirable. |
But if Also, I have unpushed code which will add support for |
But
|
OK, I see your point. Could you please add new entry to CHANGELOG? |
Done! Let me now if the entry is unclear. |
Rebased and merged! I will prepare new version tomorrow. |
Thank you @niksy! |
Depending on the configuration bundlers like Webpack will load the
browser
fielder instead of themain
file. Besides users older versions of Webpack that don't supportmodule
this also affects us because we currently disablemodule
in our project due to some bug.This change removes the
browser
field but forces both unpkg and jsdelivr to use the UMD version.