New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running browser tests on PRs #210

Open

niksy opened this issue Apr 6, 2022 · 0 comments

Assignees

Labels

Owner

niksy commented Apr 6, 2022 •

edited

Loading

GitHub Actions don’t allow sharing secrets in PRs so we can’t run BrowserStack tests.

Maybe we can run classic Chrome tests
- Run with this action: https://github.com/GabrielBB/xvfb-action
Check how we can see if secret is available or if it’s specific event (PR from non-maintainer)
Check official recommendation: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
Specific command: https://github.com/imjohnbo/ok-to-test
Custom configuration: https://cloudtruth.com/blog/skipping-jobs-in-github-actions-when-secrets-are-unavailable-securely-inject-configuration-secrets-into-github/
- This seems like best solution

Implemented in throttle-debounce: niksy/throttle-debounce@af2aa34

The text was updated successfully, but these errors were encountered:

niksy added the question label

niksy self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment