Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wigner 6j for non-integer sum triads #158

Closed
petermao opened this issue Oct 4, 2023 · 1 comment
Closed

Wigner 6j for non-integer sum triads #158

petermao opened this issue Oct 4, 2023 · 1 comment
Milestone

Comments

@petermao
Copy link
Collaborator

petermao commented Oct 4, 2023

In PR #148, I had left the return value for non-integer sums as np.nan because I didn't know any better:

if not SumIsInteger:
msg = "WARNING!!\n" + msg
msg += (
"For the 6j-Symbol:\n ⎰%3.1f %3.1f %3.1f⎱\n ⎱%3.1f %3.1f %3.1f⎰"
% (j1, j2, j3, J1, J2, J3)
)
msg += "\n6j-Symbol is undefined when any triad has a non-integer sum"
if verbose:
print(msg)
return np.nan

If Wolfram is right, the proper value to return is 0.

@nikolasibalic
Copy link
Owner

Released in ver 3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants