Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement swap command #8

Open
nikitabobko opened this issue Oct 31, 2023 · 8 comments
Open

Implement swap command #8

nikitabobko opened this issue Oct 31, 2023 · 8 comments
Labels
feature-proposal A well defined feature proposal good-first-issue Easy to fix issues. Good for newcomers triaged The issue makes sense to maintainers

Comments

@nikitabobko
Copy link
Owner

https://i3wm.org/docs/userguide.html#_swapping_containers

@jeffwindsor
Copy link

@nikitabobko I would like to try my hand at this "good-first-issue".

@jeffwindsor
Copy link

Looking over the background information in

I became confused between the terminology and intent of this feature. Is the intent that the swap is applied to Leaf Nodes (Windows) or Non-Leaf Nodes (Containers, excluding workspaces)?

@nikitabobko
Copy link
Owner Author

Is the intent that the swap is applied to Leaf Nodes (Windows) or Non-Leaf Nodes (Containers, excluding workspaces)?

@jeffwindsor Leaf nodes (windows). It should work similar to move command.

@nikitabobko
Copy link
Owner Author

@jeffwindsor
Copy link

Excellent. Do you have a structural preference for reuse? as in should the swapWindows function be moved to a shared location as part of this second use?

@jeffwindsor
Copy link

jeffwindsor commented Jul 26, 2024

I noticed the .swiftpm directory was not excluded in the .gitiginore. Is it ok to add that to the project .gitignore?
If not, no problem, I will add it else where on my machine.

@jeffwindsor
Copy link

@nikitabobko I forgot to tag you on the above questions.

@nikitabobko
Copy link
Owner Author

nikitabobko commented Aug 1, 2024

These are insignificant questions, proceed as you think is best

@nikitabobko nikitabobko added the triaged The issue makes sense to maintainers label Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-proposal A well defined feature proposal good-first-issue Easy to fix issues. Good for newcomers triaged The issue makes sense to maintainers
Projects
None yet
Development

No branches or pull requests

2 participants