-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
accordion-padding per workspace #558
Comments
@theherk no, it's not possible, and I think it's conceptually wrong to render containers differently based on a workspace. Frankly speaking, I don't understand why would someone want to set paddings to zero, since it makes it hard to understand that there are more than 1 window in the container, and it makes it hard to know the orientation of the accordion. That being said, you can easily patch AeroSpace to achieve what you need: diff --git a/Sources/AppBundle/layout/layoutRecursive.swift b/Sources/AppBundle/layout/layoutRecursive.swift
index d1d00287..a9513c6f 100644
--- a/Sources/AppBundle/layout/layoutRecursive.swift
+++ b/Sources/AppBundle/layout/layoutRecursive.swift
@@ -123,7 +123,7 @@ private extension TilingContainer {
func layoutAccordion(_ point: CGPoint, width: CGFloat, height: CGFloat, virtual: Rect, _ context: LayoutContext) {
guard let mruIndex: Int = mostRecentChild?.ownIndexOrNil else { return }
for (index, child) in children.enumerated() {
- let padding = CGFloat(config.accordionPadding)
+ let padding = CGFloat(context.workspace.name == "zed-workspace" ? 0 : config.accordionPadding)
let (lPadding, rPadding): (CGFloat, CGFloat) = switch index {
case 0 where children.count == 1: (0, 0)
case 0: (0, padding) In future, it will be easier to install AeroSpace directly from sources #530 |
accordion-padding
per workspace somehow? I can't see setting it aside from the general attribute, but it would be nice. Reason being Zed editor opens several windows but has its own project switching. So I put them all on the same workspace, but don't need the accordion padding.
Conceptually, it maybe should be a separate "fullscreen-like" layout (NB: don't confuse it with the |
To be even more candid, I even lack the understanding for I prefer |
@nikitabobko: Is it possible to set
accordion-padding
per workspace somehow? I can't see setting it aside from the general attribute, but it would be nice. Reason being Zed editor opens several windows but has its own project switching. So I put them all on the same workspace, but don't need the accordion padding.I didn't want to open another issue as this doesn't really seem like a bug and is closely related to this question.
Originally posted by @theherk in #374 (comment)
The text was updated successfully, but these errors were encountered: