Prettyprinter renders Embedded \n in " strings is into a newline

[kelfink]

Is there an option to preserver the embedded new-line char? Either the parser or the pretty-printer is processing them into the real thing, which corrupts my code.
thanks, (observed in 0.9.3

<?php>
require '../lib/bootstrap.php';
$parser        = new PHPParser_Parser(new PHPParser_Lexer);
$prettyPrinter = new PHPParser_PrettyPrinter_Default;
$filenames = array('testfiles/BarClass.php');
try {
    foreach ($filenames as $filename) {

        $code = file_get_contents($filename);
        // parse
        $stmts = $parser->parse($code);
        // pretty print
        $code = "<?php \n" . $prettyPrinter->prettyPrint($stmts) . "\n";
        file_put_contents($filename . '.f.php', $code);
    }
} catch (PHPParser_Error $e) {
    echo 'Parse Error: ', $e->getMessage();
}

File:

<?php
input file BarClass.php
class BarClass {
 // sample
    public function bar2() {
        echo "foo bar";
        echo "foo\nbar";
        echo 'baz\nmo';
        echo "happy birthday";
    }
}

Output file BarClass.php.f.php

<?php 
class BarClass
{
    // sample
    public function bar2()
    {
        echo 'foo bar';
        echo 'foo
bar';
        echo 'baz\\nmo';
        echo 'happy birthday';
    }
}

thanks

[nikic]

The parser provides strings "as seen by PHP", i.e. in already parsed form. It does not retain the formatting of the string. Pretty printing with support for retaining formatting is discussed in #41.

In #26 you can find a solution for your particular issue with strings. The custom lexer will provide an originalValue attribute for constant encapsed strings, which you can then use in the pretty printer via:

public function pScalar_String(PHPParser_Node_Scalar_String $node) {
    return $this->pNoIndent($node->getAttribute('originalValue'));
}

This approach will not work for non-constant (interpolated) strings though.

[popstikle2]

@nikic I followed your steps on #41 and #26. But now if I have HEREDOC string it will exclude it from the pretty printer. Can you check it and tell me what I can do to keep the HEREDOC?