Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new "opera" and "ie" esbuild targets #74

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

jfsiii
Copy link
Contributor

@jfsiii jfsiii commented Dec 5, 2022

Background

I saw these warnings even though esbuild shows it supports opera

[esbuild-plugin-browserslist] Skipping unknown target: entry=opera 92, browser=opera, version=92
[esbuild-plugin-browserslist] Skipping unknown target: entry=opera 91, browser=opera, version=91

PR changes

The minimum supported version of esbuild is 0.15.12 so this updates the code to use those types.

Notes

The latest version of esbuild is 0.15.18 which has a deno type but I don't that that changes anything here

I'm not sure if there any other code changes which are needed. Please let me know or hopefully this PR is useful as a starting point

@nihalgonsalves nihalgonsalves changed the title Update types to match esbuild 0.15.12 feat: add support for new "opera" and "ie" esbuild targets Dec 6, 2022
Copy link
Owner

@nihalgonsalves nihalgonsalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nihalgonsalves nihalgonsalves merged commit c4720bc into nihalgonsalves:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants