The change fetching robot is still broken for specs and docs

[ACharbonneau]

The specifications-and-documentation repo is private.

For the continuous integration robot having it use cfde-bots ALLTHEACTIONS credential make it work, but it didn't work in the update workflows:

• https://github.com/nih-cfde/published-documentation/blob/dev/.github/workflows/update_cookbook_preview.yml
• https://github.com/nih-cfde/published-documentation/blob/dev/.github/workflows/update_cookbook_stable.yml
• https://github.com/nih-cfde/published-documentation/blob/dev/.github/workflows/update_specs_preview.yml
• https://github.com/nih-cfde/published-documentation/blob/dev/.github/workflows/update_specs_stable.yml

The action that is breaking is actions/checkout@v2. It only sort of can do private submodules. See: actions/checkout#287

My current attempt at a solution was from actions/checkout#116 (comment) but clearly didn't work.

In those issues, there is also a suggestion about using SSH keys. cfde-bot has an SSH key as a secret called RTDprivaterepo if you want to try that route.

[ACharbonneau]

hmm. update cookbook stable is working. the other three are not. maybe i just have some kind of typo?

[ACharbonneau]

It's just the specifications-and-documentation auth that's not working now.

Run git -c "http.extraheader=Authorization: basic ***" submodule update --init --recursive --remote docs/specifications-and-documentation
Submodule 'docs/specifications-and-documentation' ([email protected]:nih-cfde/specifications-and-documentation.git) registered for path 'docs/specifications-and-documentation'
Cloning into '/home/runner/work/published-documentation/published-documentation/docs/specifications-and-documentation'...
Warning: Permanently added the RSA host key for IP address '140.82.112.4' to the list of known hosts.
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:nih-cfde/specifications-and-documentation.git' into submodule path '/home/runner/work/published-documentation/published-documentation/docs/specifications-and-documentation' failed
Failed to clone 'docs/specifications-and-documentation'. Retry scheduled
Cloning into '/home/runner/work/published-documentation/published-documentation/docs/specifications-and-documentation'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of '[email protected]:nih-cfde/specifications-and-documentation.git' into submodule path '/home/runner/work/published-documentation/published-documentation/docs/specifications-and-documentation' failed
Failed to clone 'docs/specifications-and-documentation' a second time, aborting
Error: Process completed with exit code 1.

I wonder if I can literally give it the same code as the CI.

[ACharbonneau]

Good news: scoped CI code seems to work. Bad news: apparently the PR action is about to stop working https://github.com/nih-cfde/published-documentation/runs/1364822556?check_suite_focus=true

[ACharbonneau]

Also, it thinks that the submodule hasn't updated but it has.

[marisalim]

this is the part that is going to be deprecated - https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

[ACharbonneau]

yeah I already fixed that

[ACharbonneau]

currently trying https://ehlers.berlin/blog/private-submodules-in-github-ci/