Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loading of external resources #7

Open
anderspetersson opened this issue May 18, 2014 · 2 comments · May be fixed by #9
Open

Support loading of external resources #7

anderspetersson opened this issue May 18, 2014 · 2 comments · May be fixed by #9

Comments

@anderspetersson
Copy link

As documented, this library does only support loading of local resources in fetch_resources. I would like it to support loading of resources from an external URL.

My use-case is loading user generated media files from a CDN.
@maestrofjp
Copy link

I have a patch for this if the author would accept it.

maestrofjp added a commit to maestrofjp/django-easy-pdf that referenced this issue Aug 1, 2014
@maestrofjp
Fixes nigma#7
4d22476 
Added support for protocol relative, http and https URLs.
@maestrofjp maestrofjp linked a pull request Aug 1, 2014 that will close this issue
Open
@jterskine
Copy link

@maestrofjp thanks!

cubicuboctahedron pushed a commit to cubicuboctahedron/django-easy-pdf that referenced this issue Nov 24, 2016
@maestrofjp @cubicuboctahedron
Merge maestrofjp commit: Fixes nigma#7
7d2dd82 
Added support for protocol relative, http and https URLs.

maestrofjp@4d22476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for non-local resources maestrofjp/django-easy-pdf
3 participants
@anderspetersson @maestrofjp @jterskine