Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMConnect actively blocks CareLink users with service changes (28.06.2020) #5719

Closed
benceszasz opened this issue Jun 28, 2020 · 77 comments
Closed

Comments

@benceszasz
Copy link

Hi!

There was a major upgrade in EU CareLink services (28.06.2020) and since then MMConnect module is not working anymore in EU.

Login changed
https://carelink.minimed.eu/patient/j_security_check?j_username=&j_password= throws HTTP 400
EU CareLink seems to using now the following service for logins:
https://mdtlogin.medtronic.com/mmcl/auth/oauth/v2/authorize/login

Dataservice changed
https://carelink.minimed.eu/patient/connect/ConnectViewerServlet?cpSerialNumber=NONE&msgType=last24hours&requestTime= throws HTTP 404
EU CareLink connect webapplication seems to be using the following service to fetch SGV values:
https://carelink.minimed.eu/patient/connect/data?cpSerialNumber=NONE&msgType=last24hours&requestTime=

The returned SGV data seems to be the very same JSON as earlier
lastSensorTSAsString
bgunits
lastSensorTS
...
lastSGTrend
lastSG{}
lastAlarm{}
activeInsulin{}
sgs[]
limits[]
markers[]

Could you please change the MMConnect module to support the new EU CareLink Connect services?

Thank you!

@ireneusz-ptak
Copy link
Contributor

@benceszasz I think it's better to raise it here: https://github.com/mddub/minimed-connect-to-nightscout

@benceszasz
Copy link
Author

Ok, I wasn't sure where is it maintained now.
Created a new issue in minimed-connect-to-nightscout:
mddub/minimed-connect-to-nightscout#18

@ireneusz-ptak
Copy link
Contributor

@benceszasz I wouldn't close this issue yet - NS dependencies need to be changed after development in the mentioned project is completed :(

@benceszasz
Copy link
Author

Ok, reopened for NS dependency changes after error is fixed in MMConnect

@benceszasz benceszasz reopened this Jun 28, 2020
@bewest
Copy link
Member

bewest commented Jun 28, 2020

I've got a branch posted up here, there are several issues I'd like to confirm and close before publishing a new release of MMConnect. nightscout/minimed-connect-to-nightscout#1

bewest added a commit that referenced this issue Jun 28, 2020
Prepare to handle issue #5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.
@bewest
Copy link
Member

bewest commented Jun 28, 2020

The wip/bewest/mmconnect-eu branch has work to start addressing this, but again has not been confirmed as working. #5721

@bewest
Copy link
Member

bewest commented Jun 29, 2020

Thanks to @FredMK, the wip/bewest/mmconnect-eu is available for testing changes that should accommodate Medtronic's new updates to Carelink.

bewest added a commit that referenced this issue Jun 29, 2020
Prepare to handle issue #5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.
@ffernandezro
Copy link

@bewest
After performing the deployment to heroku including the changes, now I get the following error
I appreciate your help to solve this problem:

MiniMed Connect error: Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: carelink.minimed.eu. is not in the cert's altnames: DNS:mdtlogin.medtronic.com, DNS:mdtsts.medtronic.com

@norbicz
Copy link

norbicz commented Jun 30, 2020

I have the same issue after deployment to heroku.

MiniMed Connect error: Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: carelink.minimed.eu. is not in the cert's altnames: DNS:mdtlogin.medtronic.com, DNS:mdtsts.medtronic.com

@FredMK
Copy link

FredMK commented Jun 30, 2020

I tried to fix the ERR_TLS_CERT_ALTNAME_INVALID error, but I cannot find a way, cannot understand why. The workaround is to use the 13.0.1 version from NS, currently this is the master branch, with this there is no problem.

@norbicz
Copy link

norbicz commented Jun 30, 2020

I tried to fix the ERR_TLS_CERT_ALTNAME_INVALID error, but I cannot find a way, cannot understand why. The workaround is to use the 13.0.1 version from NS, currently this is the master branch, with this there is no problem.

With master I have 404 http, with fix the issue I mentioned.
One comment above my first one somebody had the same problem.

Maybe it is the combination of more cases, I can try manual file edit on my fork from master but I am not sure if it will change anything.

@danfarcas1972
Copy link

The wip/bewest/mmconnect-eu branch has work to start addressing this, but again has not been confirmed as working. #5721

When do you think that the package.json from cgm-remote-monitor/master will be modified to use it without fork?

@bewest
Copy link
Member

bewest commented Jul 2, 2020

Please see #5725 (comment) for getting hotfix for cgm-remote-monitor.

@bewest
Copy link
Member

bewest commented Jul 2, 2020

@tudorfarcas2002 apologies, was hoping to get a bit more confirmation traced through. This should correctly change both the package.json as well as the shrinkwrap, pending confirmation.

@ffernandezro
Copy link

Hello, I am desperate, I continue with problems since updating carelink servers in the US.
This is the message that continues to appear in the log that I see from heroku

MiniMed Connect error: Error: Bad response from CareLink: {"statusCode":404,"body":"","headers":{"server":"---","date":"Sat, 04 Jul 2020 12:26:37 GMT","strict-transport-security":"max-age=31536000; includeSubDomains; preload","content-length":"9","content-type":"text/html; charset=UTF-8","access-control-allow-headers":"origin, content-type, accept, authorization","access-control-allow-methods":"GET, POST, PUT, DELETE, OPTIONS, HEAD","access-control-allow-credentials":"true","access-control-allow-origin":"*, https://mdtlogin.medtronic.com","x-frame-options":"sameorigin","x-xss-protection":"1; mode=block","vary":"Origin"},"request

Someone who can guide me on what I can do to get back on track for my diabetes.
I really appreciate the help you can give me

@FredMK
Copy link

FredMK commented Jul 4, 2020

@ffernandezro Which version/branch is currently deployed to your server? I just check the latest version hotfix/2020-06-28/carelink and it's working with US and EU servers as well.

@ffernandezro
Copy link

@FredMK I get that error with the master version/branch. I tried with hotfix/2020-06-28/carelink and i got this error

MiniMed Connect error: Error [ERR_TLS_CERT_ALTNAME_INVALID]: Hostname/IP does not match certificate's altnames: Host: carelink.minimed.eu. is not in the cert's altnames: DNS:mdtlogin.medtronic.com, DNS:mdtsts.medtronic.com

Thanks a lot!!!

@FredMK
Copy link

FredMK commented Jul 4, 2020

@ffernandezro Pull the changes from branch hotfix/2020-06-28/carelink and deploy it again, you version is not the latest for that branch and there was a problem with that.

@ffernandezro
Copy link

@FredMK Ok I hope not to make mistakes, I am not an expert technician.
I will comment on the results
Thanks for your help,

@ffernandezro
Copy link

@FredMK Oh my god it doesn´t work.
Steps.

  1. Deleted my git project ffernandezro/ cgm-remote-monitor from
  2. Deleted my herokuapp
  3. Create ffernandezro/ cgm-remote-monitor forked from nightscout/cgm-remote-monitor
  4. Pull the changes FROM branch ffernandezro/ cgm-remote-monitor/hotfix/2020-06-28/carelink TO ffernandezro/ cgm-remote-monitor/master
  5. Deploy FROM ffernandezro/cgm-remote-monitor/master to heroku.

Get this in log:
MiniMed Connect error: Error: Bad response from CareLink: {"statusCode":404,"body":"","headers":{"server":"---","date":"Sat, 04 Jul 2020 17:30:49 GMT....

Thank you for you patient and your time

@FredMK
Copy link

FredMK commented Jul 4, 2020

@ffernandezro I just forked your repo and deployed it to my Heroku and it's working. To be honest, currently I don't have BG data, but there is no error message in the log.
That is you MMCONNECT_SERVER variable in Heroku?

@ffernandezro
Copy link

@FredMK MMCONNECT_SERVER value is EU and other variables as MMCONNECT_USER_NAME MMCONNECT_PASSWORD

@danfarcas1972
Copy link

@FredMK Oh my god it doesn´t work.
Steps.

  1. Deleted my git project ffernandezro/ cgm-remote-monitor from
  2. Deleted my herokuapp
  3. Create ffernandezro/ cgm-remote-monitor forked from nightscout/cgm-remote-monitor
  4. Pull the changes FROM branch ffernandezro/ cgm-remote-monitor/hotfix/2020-06-28/carelink TO ffernandezro/ cgm-remote-monitor/master
  5. Deploy FROM ffernandezro/cgm-remote-monitor/master to heroku.

Get this in log:
MiniMed Connect error: Error: Bad response from CareLink: {"statusCode":404,"body":"","headers":{"server":"---","date":"Sat, 04 Jul 2020 17:30:49 GMT....

Thank you for you patient and your time

I have had the same error but it was resolved by modifying only one line in my package.json, some link to FredMK solution for mmconnect . All problems was fixed without deleting my Heroku Nightscout, only redeploy my master

@jhuang234
Copy link

@FredMK Oh my god it doesn´t work.
Steps.

  1. Deleted my git project ffernandezro/ cgm-remote-monitor from
  2. Deleted my herokuapp
  3. Create ffernandezro/ cgm-remote-monitor forked from nightscout/cgm-remote-monitor
  4. Pull the changes FROM branch ffernandezro/ cgm-remote-monitor/hotfix/2020-06-28/carelink TO ffernandezro/ cgm-remote-monitor/master
  5. Deploy FROM ffernandezro/cgm-remote-monitor/master to heroku.

Get this in log:
MiniMed Connect error: Error: Bad response from CareLink: {"statusCode":404,"body":"","headers":{"server":"---","date":"Sat, 04 Jul 2020 17:30:49 GMT....
Thank you for you patient and your time

I have had the same error but it was resolved by modifying only one line in my package.json, some link to FredMK solution for mmconnect . All problems was fixed without deleting my Heroku Nightscout, only redeploy my master

@tudorfarcas2002
would you like help share which line you delete in package.json?
I deploy #5725 hotfix and got the same error message as @ffernandezro

2020-07-08T06:02:51.653864+00:00 app[web.1]: MiniMed Connect error: Error: Bad response from CareLink: {"statusCode":404,"body":"","headers":{"server":"---","date":"Wed, 08 Jul 2020 06:02:51 GMT","strict-transport-security":"max-age=31536000; includeSubDomains; preload","content-length":"9","content-type":"text/html; charset=UTF-8","access-control-allow-headers":"origin, content-type, accept, authorization","access-control-allow-methods":"GET, POST, PUT, DELETE, OPTIONS, HEAD","access-control-allow-credentials":"true","access-control-allow-origin":"*, https://mdtlogin.medtronic.com","x-frame-options":"sameorigin","x-xss-protection":"1; mode=block","vary":"Origin"},"request":{"uri":{"protocol":"https:","slashes":true,"auth":null,"host":"carelink.minimed.eu","port":443,"hostname":"carelink.minimed.eu","hash":null,"search":null,"query":null,"pathname":"/patient/j_security_check","path":"/patient/j_security_check","href":"https://carelink.minimed.eu/patient/j_security_check"},"method":"POST","headers":{"Host":"carelink.minimed.eu","Connection":"keep-alive","Accept":"text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:41.0) Gecko/20100101 Firefox/41.0","Accept-Encoding":"gzip,deflate,sdch","Accept-Language":"en-US,en;q=0.8","content-type":"application/x-www-form-urlencoded","content-length":68}}}

@danfarcas1972
Copy link

@tudorfarcas2002
would you like help share which line you delete in package.json?

You need to change the line "minimed-connect-to-nightscout" (in mine package was at line 78 but someone else have 91...) in package.json in cgm-remote-monitor/master with this :
"minimed-connect-to-nightscout": "FredMK/minimed-connect-to-nightscout#6a6c422a5d7857b2b1ab959fdf2ea17db61defe6",

@psonnera
Copy link

@FredMK yes it's looking very nice running in NPM. I'll leave it running overnight.

@FredMK
Copy link

FredMK commented Dec 11, 2020

@psonnera update before that, I just found a bug in token refresh.

@ffernandezro
Copy link

@FredMK

2020-12-11T22_34_04_173Z-debug.log

C:\Personal\Nightscout\minimed-connect-to-nightscout-wrapper-master>node run.js
internal/modules/cjs/loader.js:883
throw err;
^

Error: Cannot find module 'dotenv'
Require stack:

  • C:\Personal\Nightscout\minimed-connect-to-nightscout-wrapper-master\run.js
    ←[90m at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)←[39m
    ←[90m at Function.Module._load (internal/modules/cjs/loader.js:725:27)←[39m
    ←[90m at Module.require (internal/modules/cjs/loader.js:952:19)←[39m
    ←[90m at require (internal/modules/cjs/helpers.js:88:18)←[39m
    at Object. (C:\Personal\Nightscout\minimed-connect-to-nightscout-wrapper-master\run.js:4:1)
    ←[90m at Module._compile (internal/modules/cjs/loader.js:1063:30)←[39m
    ←[90m at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)←[39m
    ←[90m at Module.load (internal/modules/cjs/loader.js:928:32)←[39m
    ←[90m at Function.Module._load (internal/modules/cjs/loader.js:769:14)←[39m
    ←[90m at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)←[39m {
    code: ←[32m'MODULE_NOT_FOUND'←[39m,
    requireStack: [
    ←[32m'C:\Personal\Nightscout\minimed-connect-to-nightscout-wrapper-master\run.js'←[39m
    ]
    }

BR.

@ffernandezro
Copy link

@FredMK
It was a problem with my $path and git software.
It works!!

node run.js is working on my laptop....

Thanks!!

BR.

@FredMK
Copy link

FredMK commented Dec 12, 2020

Be sure that you are updating, I fixed a bug again. Just run npm update.

@psonnera
Copy link

It's been up all night, I believe you're on the right track.

@ffernandezro
Copy link

Everynight ok on my side!!
I think also it's the right track

BR.

@ffernandezro
Copy link

It seems ok, but this is log till now:

Error: timeout of 10000ms exceeded
stack: Error: timeout of 10000ms exceeded
at createError (C:\Personal\Nightscout\minimed-connect-to-nightscout-wrapper-master\node_modules\minimed-connect-to-nightscout\node_modules\axios\lib\core\createError.js:16:15)
at ClientRequest.handleRequestTimeout (C:\Personal\Nightscout\minimed-connect-to-nightscout-wrapper-master\node_modules\minimed-connect-to-nightscout\node_modules\axios\lib\adapters\http.js:256:16)
at Object.onceWrapper (events.js:421:28)
at ClientRequest.emit (events.js:315:20)
at TLSSocket.emitRequestTimeout (_http_client.js:784:9)
at Object.onceWrapper (events.js:421:28)
at TLSSocket.emit (events.js:327:22)
at TLSSocket.Socket._onTimeout (net.js:483:8)
at listOnTimeout (internal/timers.js:554:17)
at processTimers (internal/timers.js:497:7)

BR.

@psonnera
Copy link

It crashed and went looping...
Sat Dec 12 2020 13:24:31 GMT+0100 (Central European Standard Time) Refresh EU token
Sat Dec 12 2020 13:24:31 GMT+0100 (Central European Standard Time) Refresh EU token failed (Error: Request failed with status code 403)
But when you stop it and restart it, it just resumes working.
Would it be possible to detect 403 and restart authentication automatically from the beginning?
I apologize I didn't look into the code, would need to dive in the actual thing....

@FredMK
Copy link

FredMK commented Dec 12, 2020

It was already fixed, that's why I wrote that update the program to the latest version.

@psonnera
Copy link

I did update it. Let me copy again.

@FredMK
Copy link

FredMK commented Dec 12, 2020

You need to run npm update as well, because the fix is in the dependency.

@psonnera
Copy link

Exactly what I though now. Updated the folder but didn't npm install or update. Sorry.

aslzo added a commit to aslzo/cgm-remote-monitor that referenced this issue Dec 13, 2020
* mgdl -> mg/dl

* Release ref update v2 (nightscout#5301)

* Updated release name and number

* Added missing version number

* Added missing version number

* Fix auth dialog sizing error (nightscout#5315)

* Fix auth dialog sizing error (nightscout#5314)

* Fix auth dialog sizing error

* Fix Client Init After Auth

(cherry picked from commit 1bf416c)

* update NS minor version

* Bump version to 13.0.2-dev

* fix some random test failures (nightscout#5341)

* fix some random test failures

* use typeof to test for existence

* Added support for asking delta

* Added time reference

* Made delta reading more informative

* Corrected time reference

* Try shortening the response

* Revert attempt

* Updated templates and documentation

* Minor improvement in response when delta is 0

* German translations improved and added (nightscout#5360)

* Fix Alexa Launch and SessionEnded Requests (nightscout#5377)

* Fix Alexa Launch Request

* Allow LaunchRequest to handle intent if set, change shouldEndSession from string to bool

* Fix SessionEndedRequest

* Fix nightscout#5149 - discord link on CONTRIBUTING.md doesn't do anything (nightscout#5380)

* Fix nightscout#5146 - display of treatment with only Fat and Protein set (nightscout#5381)

* Basic report page style fixes and updates (nightscout#5387)

* Add missing Polish translations and improve existing (nightscout#5382)

* Add missing Polish translations and improve existing

* Improve translations

* Addressed virtual assistant usage with Authentication Roles (nightscout#5388)

* Fix nightscout#5347 - Addressed auth roles

* Unification

* Fix timeago alarms (again). The changes to the rendered had an unintended consequence of triggering the timeago detection less frequently, causing the code to think the client has been hibernating, thus suppressing the alarms. The update changes the clock to be updated more frequently (this updating the hibernation detection), fixing the issue

* Remove the server side test

* Fix Graph Display Without Recent Devicestatus (nightscout#5409)

* Update Russian (nightscout#5415)

Corrected major and minor misprints and mistakes - particularly in variables, new translations added

* Add server teardown ability (nightscout#5410)

* adding teardown event to ctx.bus

* adding teardown support for mmconnect and bridge plugins

* Additional German Translations and corrections (nightscout#5405)

* Cleaned up changed translations

* Added Virtual Assistant Translations

* Fix nightscout#5188 - move predictions to bundle and don't render chart on predictions offset change (nightscout#5395)

* Fix nightscout#5188 - move predictions to bundle and don't render chart on predictions offset change

* Fix predictions show for day to day

* Move toolbar and authentication status to partial and include on each page (nightscout#5393)

* Move authentication status to partial and include on each page

* Move toolbar to partial

Co-authored-by: Sulka Haro <[email protected]>

* Virtual assistant code simplification (nightscout#5400)

* Moved duplicate plugin code to single location, and small improvements

* Defined _each()

* Pr/5379 (nightscout#5441)

* Release 13.0.1 (nightscout#5329)

* Release ref update v2 (nightscout#5301)

* Updated release name and number

* Added missing version number

* Added missing version number

* Fix auth dialog sizing error (nightscout#5315)

* Fix auth dialog sizing error (nightscout#5314)

* Fix auth dialog sizing error

* Fix Client Init After Auth

(cherry picked from commit 1bf416c)

* update NS minor version

* Added handlers and translations for CGM info

* Defined translate()

* Fixed sensor state reference

* Improved wording for tx age response

* Improved wording for session duration response

* Updated documentation and templates

* Updated README.md TOC and a reference to it

* Added CGM battery info

* Added unit reference to CGM battery levels

* Added handlers and translations for CGM info

* Defined translate()

* Fixed sensor state reference

* Improved wording for tx age response

* Improved wording for session duration response

* Updated documentation and templates

* Updated README.md TOC and a reference to it

* Added CGM battery info

* Added unit reference to CGM battery levels

* Updated API reference in Google Home template

Co-authored-by: Caleb <[email protected]>

* Volunteer for Polish translations (nightscout#5396)

* Api3 output renderers (nightscout#5425)

* APIv3: adding framework for various output renderers

* APIv3: adding xml output renderer

* APIv3: adding csv output renderer

* APIv3: documenting supported output renderers

* APIv3: testing output renderers

* Restore glucose distribution test (nightscout#5434)

* Increase coverage of tests on units utility and clean up timeago test (nightscout#5435)

* Increase coverage of tests on units utility

* clean up timeago test

* Refactor to encapsulate duplicated settings logic (nightscout#5426)

* Encapsulate duplicate settings checks inside functions

* Simplify settings::isAlarmEventEnabled()

* Send coverage reports to Codacy (nightscout#5444)

* Send coverage reports to Codacy

* Action secrets may not be read from forks :(

* Let's see if this fixes the path & key passing

* Ok one more try for the Actions env

* Run tests and coverage separately

* Try increasing the admintools test runtime for Node 10

* Run tests only once

* Resolve unnecessary uses of eslint-ignore (nightscout#5436)

* Resolve unnecessary disabling of no-undef eslint rule

* Resolve unnecessary disabling of no-prototype-builtins eslint rule

* Resolve unnecessary disabling of no-unused-vars eslint rule

* Resolve unnecessary disabling of no-empty eslint rule

* Fix eslint errors and add npm script for eslint (nightscout#5427)

* re-enable auth check for device status routes

* Resolve eslint errors

* Add npm script for eslint

* Correct regex for express extension middleware and add tests for expected behaviour

* Resolve lint error in virtual assistant base

* Update index.js

* Update index.js

* Remove redundant checks on entry ID (nightscout#5440)

* Run CI Action for Pull Requests

* Update DayToDay report for Loop Overrides (nightscout#5452)

Add Loop override name/reason as text to the grey bar at the top of the graph.

* Fix earlier merge error with predictions having moved to the report bundle

* fix brushing loop (nightscout#5499)

* Update README.md (nightscout#5480)

Clarified that the "bridge" plugin is for Dexcom Share ("Dexcom" didn't appear at all in the read me), fixed a few typos, and added line 444 about the BRIDGE_SERVER variable.

* Added period of days into headline of glucose distribution and percen… (nightscout#5428)

* Added period of days into headline of glucose distribution and percentil chart report

I make screencopies of the glucose distribution and percential chart report for my diabtes consultant and had to manually add the period of days to the report everytime because it was not shown in the report itself.
I added the period of days this with a small number of lines of code and think this is helpful for other too.

* removed comments as requested

removed comments as requested

* Camelcase for new variables reportPlugins, firstDay, lastDay, countDays

* forget to save the change of reportPlugins in percentile.js

* Move app caching to a service worker (nightscout#5504)

* Move app caching to a webworker

* Code cleanup

* Code cleanup

* Make Codacy happy

* More parentheses

* Added indexes to 'entries' and 'treatments' along with other updates (nightscout#5463)

* Added compound indexes for treatments and entries collections. Updated ensureIndex to createIndex in mongo-strage.js as ensureIndex has been deprecated. Finally, updated testing/populate.js to be compatible with more recent versions of the node driver, as well as fixing a path issue.

* Fixed missing end quote in lib/server/treatments.js. Changed all newly added double quotes to single quote to match style guide.

* Removed indexes that referenced key600.

* Fix: Round interporlated mg/dL value to an integer

* Plugin to show database size (% of available space or in MiB) (nightscout#5496)

* Database size plugin - pill that displays current mongoDB database size

* Enabled dbsize by default

* Fixed bug with dbsize not shownig when size is (rounded) 0% but real bytes > 0

* Cleanup & update to iconfont generation manual

* Changed how warning/urgent levels are configured - from absolute MiB to percentage of DBSIZE_MAX

* Trying to fix random fail of APIv3 tests (nightscout#5519)

* APIv3: isolating documents from tests (not allowing clashes of calculated identifiers)

* removing unused async keyword

* client - mobile - Axis label font is scaled on small screens (nightscout#5512)

On phones or other small screens, the axis labels (especially x axis)
were previously an unreadable jumble of too-close letters

* Split view (nightscout#5518)

* Adds a 2, 3, 4 and 8 way split view option

* Updated description

* Generate the table on demand, so any number of sites from 1 to 8 generates a sensible layout

* Update readme & don't crash if a name is missing

* Allow flagging specific settings to be not exposed the /properties and /status APIs (nightscout#5525)

* Add more variables to the special list

* [DEV][FIX] Fix dbsize plugin to make it hideable again (nightscout#5529)

* [FIX] Making dbsize plugin default but hideable - removed its forced show state

* Removed unused lodash dependency

* Removed duplicate if statement (nightscout#5531)

Removed the additional if statement checking for the loop specific developer team id. This since the exact same if statement existed just above it.

* Update Dutch translations (nightscout#5532)

* Fix settings test

* Update version to 13.1.0

* Fix topbar collapse on small screens (nightscout#5562)

* Fix top bar collapsing on small screens

* Fix wide button array overflowing the button bar

* Option to switch off bolus amount outputs (nightscout#5522)

* Option to switch off bolus amount outputs (nightscout#5514)

* Fixing issue with carb value not be output when set to "none" (nightscout#5514)

* Adding additional output options (nightscout#5514)

* Adding environment variable option for 'x U and Over' option.

This option is BOLUS_RENDER_OVER with a default value of 1 and the value can be an integer or a float, e.g. 0.3, 1.5, 2, etc...

* Adding change to change the font size depending on the bolus value.

* Merge two "all" options to create an option that displays as SMB had.

* Fix d3 portrait to landscape brush failure (nightscout#5638)

* fix d3 portrait to landscape brush failure

* fix client.renderer.test for highlighBrushPoints function prototype change

* fix highlightBrush

* move brush reset inside check for valid brush

* Sanitize data from manual careportal entries so only fields with actual data are sent to the server (nightscout#5619)

* do not redirect to profile editor by default (nightscout#5671)

In a default configuration, there is no treatment data.  The code to redirect
the UI to the profile editor is buried deep within the chart rendering code for
basals.  This plugin is only supposed to go into action when enabled via
ENABLE=basal.  This commit fixes first-use experience for the default
configuration intended to draw real-time CGM traces and no basal information is
expected.  Since no basal information is expected unless plugin is enabled via
ENABLE=basal, this allows skipping instead of redirecting to the profile editor.

* Fix Issue nightscout#5486 - Device Status Days Feature (nightscout#5651)

* Device Status Days Feature

* Edits per review from @sulkaharo

* Configurable clock views (nightscout#5625)

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Update README.md

* Update README.md

* Configurable clock views

* Add remote bolus/carbs + otp entry for loop (nightscout#5598)

Add a remote bolus entry field for users on Loop, along with support for an OTP field

* Sometimes at the very start no profiles provided. (nightscout#5591)

At the first start the nightscout is crashed if profile not full.

* Fixes nightscout#4991 - Now selects basal profile based day by day (nightscout#5572)

* Test profile settings

* NPM Version change

* Use console log

* Use console log for client

* Use console log for client.sbx

* Use console log for client.ddata

* Use console log for client again

* revert

* Added multi-profile reporting capabilities

Co-authored-by: VIS TFS Admin <[email protected]>

* prepare hotfix for MMConnect/EU - 2020-06-28

Prepare to handle issue nightscout#5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.

* bump pointing at right tag

* prepare hotfix for MMConnect/EU - 2020-06-28

Prepare to handle issue nightscout#5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.

* bump pointing at right tag

* hotfix attempt 2 - carelink 2020 sso updates

* hotfix 3 - attempt 3 at carelink 2020 sso updates

* attempt 4 at hotfix for nightscout

Based on more reliable version of minimed-connect-to-nightscout....
This is testing the hotfix.  When it works, we will bump this one more
time with the newly released version.

* hotfix 5 - incorporates latest axios changes

* Fix for boluscalc issue (nightscout#5729)

Boluscalc fix & remove integer validation from BG input field

* npm install --save minimed-connect-to-nightscout@^1.4.0

* Change DISPLAY_UNITS to use readENV's default value and added several tests for DISPLAY_UNITS (nightscout#5708)

readENV() was hard coding the default value of DISPLAY_UNITS, and
ignoring the default value for no particular reason. Fixed that. Also, I
added a full test suite for DISPLAY_UNITS environment settings to make
sure that it works as intended. Finally, I've added the console log for
the DISPLAY_UNITS since there's no particular reason why we log that setting
and not others.

* Fix audit errors, button order (nightscout#5694)

* * Update packages giving npm audit errors
* Fix Mongo test that broke after update (now uses async/await on getting the connection)
* Restore original navigation bar button order

* Disable Node 10 tests

* Fix temporary target cancellation

* Added documentation on the use of Alpha Testing (nightscout#5784)

* Wip/bewest/mmconnect eu (nightscout#5731)

* prepare hotfix for MMConnect/EU - 2020-06-28

Prepare to handle issue nightscout#5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.

* bump pointing at right tag

* hotfix attempt 2 - carelink 2020 sso updates

* hotfix 3 - attempt 3 at carelink 2020 sso updates

* attempt 4 at hotfix for nightscout

Based on more reliable version of minimed-connect-to-nightscout....
This is testing the hotfix.  When it works, we will bump this one more
time with the newly released version.

Co-authored-by: Sulka Haro <[email protected]>

* * Updated several packages to remove issues from NPM audit
* Fix excess logging in settings.js
* Removed heapdump package, which was causing issues for some users

* * Limit the default number of profiles returned by the API to fix issues with users who are syncing a large amount of profiles from an APS.
* Fix profile reporting

* Upgrade Helmet to 4.0.0

* CSP and service worker improvements (nightscout#5856)

* Add connectSrc for Safari compatibiity
* Add new font URL for Google Fonts compatibility
* Reload on re-registering the worker
* Change Mongo version in github to fix builds

* Serve the CSP to everyone

* Split view CSP support (nightscout#5864)

* Parse split view frames into frameAncestors

* Re-enable CSP configuration (nightscout#5867)

* Re-enable CSP configuration

* Bump share2nightscout-bridge plugin

Use latest update from share2nightscout bridge to
make things easier.  It contains an updated
default for OUS users.

* feat Add robots.txt to disallow site crawling

* Fix dbsize for usage with Atlas (nightscout#5962)

* Openaps performance improvement (nightscout#5945)

* improve openaps plugin performance

* more performance improvements

(cherry picked from commit 076a2dd)

* correct setting notEnacted variable

* remove unnecessary debug logging

* Adapt to MongoDB Atlas (nightscout#5893)

* Fix Issue nightscout#5763 - Change $.ajax to /api/v1/profile (nightscout#5704)

* Bug fixes for Service Worker (nightscout#5970)

* Fix service worker refresh for Firefox

* Improve logging for service worker initialisation

* Skip browser cache for service worker precaching

* Prevent `Partial Content` responses in `fetch` by stripping `Range` header

* Prevent calling `filter` on an undefined property when service worker cache is empty

* Bug fixes for Service Worker

*    Fixes nightscout#5920
*    Fixes nightscout#5943

* Update service-worker.js

Removed the MP3 files from the preload to fix issues with webkit-based browsers

Co-authored-by: p5nbTgip0r <[email protected]>
Co-authored-by: Sulka Haro <[email protected]>

* Optimize Nightscout database usage (nightscout#5947)

* On periodic polls, only load delta for CGM data, treatments and device statuses
* Serve basic CGM data API queries from in-memory cache. Increases the Nightscout memory footprint but should significantly reduce the Mongo load
* Serve device status, CGM and treatment records from memory cache
* Support count parameter in /profile

* Bumping version to 14.0.0 given this is a relatively large update and we want people on Atlas to all migrate to this version

* Remove logging statements

* fix brushing recursion

* Normalize treatments to support absolute doses from the amount field

* Add Loop Carbs foodType, absorptionTime to Reports for ISSUE nightscout#5701 (nightscout#5702)

* add carb foodType, absorptionTime to reports

* Update README to point to new docs

* Fix `Treatments` report for `mmol/L` users

Fixed a typo to a client function name

* Bump version to 14.0.1

* Bump dev to 14.0.2

* Serve Last-Modified header for the service worker to help with some browsers misdetecting caching

* Cleaned old appcache references

* * Remove unnecessary logging to help with Papertrail limits
* Load more treatments and entries to fix caching issues (need to add better cache invalidation to really fix this)

* When merging inserts and updates from the database, ensure we always use the new data over the old data

* Bump treatment delta loading to four hours

* One more increase to treatment load time to cover long overrides

* * Bump version to 14.0.3
* Fix a bug in the REST API query for profiles

* Bumped up the number of treatments loaded / day for reporting

* Fix reports unit test

* Bump treatments default limit default to 1000 objects for queries that include other query parameters

* * Require created_at for Treatments on insert
* Refactoring the cache: moved to another file and support flushing from bus events

* Add support for CGM data and device statuses. Refactor dataloader to use the new model and reduce queries back down

* Fix data order for REST API

* * Add cache update events to websocket API
* Remove the validation for created_at in REST API ;(

* Remove excess logging

* Bump version to .4

* Bump version to 14.0.5 and fix nightscout#6050

* Fix Pebble API detecting mmol units from settings

* Make settings parsing whitespace tolerant

* * Fix security test
* Change boot and caching to expose Mongo connection errors

* Don't report an error on every reconnect

* Less intimidating error page on start, which also checks for api_secret

* Add file missing from last commit

* Fix tests

* Remove require statement breaking deploys

* Update --feature-request--.md

* Update --bug-report.md

* Update --individual-troubleshooting-help.md

* Fix memory leak and cache update issues in 14.0.4 (nightscout#6133)

* Fix a memory leak in 14.0.4
* Fix linter error in ddata.js
* Move data retention periods to caching
* Update _id of inserted entries and device status so merging to cache works correctly
* Reset the data in ddata before updating
* Fix typo on entry cache retention period
* Have device status cache retention period follow configuration
* Fix _id injection in treatments

* Add error cat to error page

* Fix MONGODB_URI reference in error message

* Bump version to 14.0.6

* Support uploading device statuses in batches (nightscout#6147)

* Support uploading device statuses in batches
* Correctly report batch insertion results

* Make empty cache detection a bit more aggressive to account for cache flush and data insert happening concurrently

* * Bump version to 14.0.7
* Add onerror handler for pushover

* Update README.md

Explicitly link to the application template in Github

* Fixed nightscout#5852 - Updated Google Home setup steps (nightscout#6195)

* Fix broken swagger for APIv3 (nightscout#6201)

* APIv3: isolating documents from tests (not allowing clashes of calculated identifiers)

* removing unused async keyword

* fixing api v3 swagger and moving it to /api3-docs

Co-authored-by: Petr Ondrusek <[email protected]>
Co-authored-by: Petr Ondrůšek <[email protected]>

* Use lodash.get() in virtual assistant API endpoints (v2) (nightscout#6199)

* Fixed nightscout#5632 - Improved value resolution

* More value resolution improvements

* Fixed a couple object paths

* Corrected setup of `dbsize` for virtual assistants (nightscout#6270)

* Corrected db size config for virtual assistants

* Language fix, improvements, added dbsize to virtAsst config

* Using env

* Added logging

* Debug logging

* Different logging

* More troubleshooting

* Another try

* Reverted stuff, added dbsize to server defaults

* Fixed test

* Fixed another test

* Create config.yml

* Delete --individual-troubleshooting-help.md

* Update config.yml

* Fix batch (nightscout#6248)

* Use the delta plugin data to show the delta in the clock views
* Update Node checks
* Fix disabling the BG alarms for simple alarms
* Load battery and other rare events up to two months back
* Possibly fixes compatibility with ios9 - needs testing
* Unified black and color clock layouts
* Update clock data every 20 seconds
* Update clock time every second
* Fix how CSP policy is set for Helmet, fixes nightscout#6260
* Authorization fix for misformatted URLs
* Added unit test for batch upload of CGM entries
* Improved / removed some logging
* Test if user is in read only mode when Nightscout starts and give an error if so

* Adding Hungarian translation to nightscout (nightscout#6037)


* Finished first round of translation for Hungarian language

* Added hungarian language to the readme file

* Fixes

* WIP

* Typo fixes and changes to translations

* Update language.js

Fixed some mistyped language keys

Co-authored-by: Andy Feher <[email protected]>
Co-authored-by: Sulka Haro <[email protected]>

* Update language.js (nightscout#6193)

Isfjell -> Istapp

Co-authored-by: Sulka Haro <[email protected]>

* nightscout#5991 Typo in translation (nightscout#6217)

Co-authored-by: Sulka Haro <[email protected]>

* add missing translations (nightscout#6346)

Co-authored-by: Sulka Haro <[email protected]>

* Updated Alexa's intents because Amazon required new ones yet again. (nightscout#6457)

* Add runtime state tracking to Nightscout, where client now checks if the server has loaded initial data from Mongo before the user is directed to the UI

* Add file missing from previous commit

* Update app.json

* Fix unit tests

* Fix the read detection to work correctly with MongoDB Atlas

* * Added basal and careportal to default plugins
* Changed report BG target to allow fractional numbers

* Increase load interval to 5 seconds

* Create codeql-analysis.yml

Co-authored-by: AdrianLxM <[email protected]>
Co-authored-by: Caleb <[email protected]>
Co-authored-by: inventor96 <[email protected]>
Co-authored-by: Jeremy Cunningham <[email protected]>
Co-authored-by: Sulka Haro <[email protected]>
Co-authored-by: Tanja <[email protected]>
Co-authored-by: Bartłomiej Szubert <[email protected]>
Co-authored-by: Andrew Dixon <[email protected]>
Co-authored-by: fedor apanasenko <[email protected]>
Co-authored-by: Petr Ondrusek <[email protected]>
Co-authored-by: Lukas Herzog <[email protected]>
Co-authored-by: Jakob <[email protected]>
Co-authored-by: jonfawcett <[email protected]>
Co-authored-by: Jonas Hummelstrand <[email protected]>
Co-authored-by: peterleimbach <[email protected]>
Co-authored-by: Adam Harrison <[email protected]>
Co-authored-by: Dominik Dzienia <[email protected]>
Co-authored-by: stephencmorton <[email protected]>
Co-authored-by: Simon Persson <[email protected]>
Co-authored-by: Cas Eliëns <[email protected]>
Co-authored-by: Ben West <[email protected]>
Co-authored-by: Matthew <[email protected]>
Co-authored-by: ireneusz-ptak <[email protected]>
Co-authored-by: josep1972 <[email protected]>
Co-authored-by: Bluefox <[email protected]>
Co-authored-by: fromorbonia <[email protected]>
Co-authored-by: VIS TFS Admin <[email protected]>
Co-authored-by: joracine <[email protected]>
Co-authored-by: Alexandre Viau <[email protected]>
Co-authored-by: Lennart Goedhart <[email protected]>
Co-authored-by: p5nbTgip0r <[email protected]>
Co-authored-by: Jeremy Cunningham <[email protected]>
Co-authored-by: kskandispersonal <[email protected]>
Co-authored-by: Petr Ondrusek <[email protected]>
Co-authored-by: Petr Ondrůšek <[email protected]>
Co-authored-by: Andras Feher <[email protected]>
Co-authored-by: Andy Feher <[email protected]>
Co-authored-by: bjornoleh <[email protected]>
Co-authored-by: Matt Gaide <[email protected]>
Co-authored-by: Lukas Herzog <[email protected]>
@psonnera
Copy link

@FredMK can I share a pdf guide for non tech users in CGM In the Cloud or do you prefer this work to remain in background?

@psonnera
Copy link

psonnera commented Dec 14, 2020

@FredMK sorry to use you as a tech support but do you have any clue why some users can't manage to npm install it? See the log here if you have time for me. https://drive.google.com/file/d/1VzIu7s6TymmfRcN9aoBVjRlftyNwJw9T/view?usp=sharing Do you need a specific .dotnet environment for npm?

@FredMK
Copy link

FredMK commented Dec 14, 2020

@psonnera Try to run it as administrator (the cmd).

@FredMK
Copy link

FredMK commented Dec 14, 2020

@psonnera I want to make sure that everything is working before make a pull request to the official repo. Do you heard any other problem?

@psonnera
Copy link

@FredMK being running one site for 3 days without interruptions and another one since yesterday without problem. That looks real good. I believe something more is needed than just nodes.js but since I also have a lot of development software installed on my PC I don't know which it is.
If you have it implemented in your private branch we can try to test it with few beta users. Like by modifying thepackage.json line to
"minimed-connect-to-nightscout": "FredMK/minimed-connect-to-nightscout#zzzzz" as we did last time with the 14.0.x issue.

@bewest
Copy link
Member

bewest commented Dec 15, 2020

I'm having a meeting tomorrow between T1Pal and Medtronic. Will see if we can discuss this and other issues and find a solution. Please contact [email protected] with any additional information or concerns.

@psonnera
Copy link

I have an answer from the Europe Direct Contact Centre:


Thank you for contacting the Europe Direct Contact Centre.

If a company is processing your personal data on the basis of your consent or a contract, you can ask the company to transfer your personal data to you.

You can also ask for your personal data to be transferred directly to another company whose services you would like to use when it’s technically feasible.

That being said, data related to health is considered as sensitive and benefits from additional safeguards. We recommend that you turn to your national data protection authority regarding your specific situation, as they are responsible for the implementation of GDPR:
https://edpb.europa.eu/about-edpb/board/members_en

We hope you find this information useful. Please contact us again if you have questions about the EU, its institutions, or activities.


Basically on a legal point of view Europe's main concern is regarding the physical location of data, not much the way data is accessed. So I guess there's not much to do on this side. Maybe another approach would be to use the software interoperability laws https://www.researchgate.net/publication/275319467_How_can_Software_Interoperability_be_achieved_under_European_Competition_Law_and_Related_Regimes with the great advanted in Europe of having the right to hack for personal use, that might match the concept of a DIY Nightscout (i.e. the app is not provided as is but must be built by the individual).

@bewest
Copy link
Member

bewest commented Dec 16, 2020

Thank you for your efforts on this! Frigyes was able to update and solve several issues. We are testing the changes. These changes are available #6657. As feedback comes in, we will complete the full release cycle.

@psonnera
Copy link

We have been monitoring 6 people using this solution for the last few days. Outside computer issues there have been no interruptions.

skibickipawel added a commit to skibickipawel/cgm-remote-monitor that referenced this issue Dec 25, 2020
* mgdl -> mg/dl

* Release ref update v2 (nightscout#5301)

* Updated release name and number

* Added missing version number

* Added missing version number

* Fix auth dialog sizing error (nightscout#5315)

* Fix auth dialog sizing error (nightscout#5314)

* Fix auth dialog sizing error

* Fix Client Init After Auth

(cherry picked from commit 1bf416c)

* update NS minor version

* Bump version to 13.0.2-dev

* fix some random test failures (nightscout#5341)

* fix some random test failures

* use typeof to test for existence

* Added support for asking delta

* Added time reference

* Made delta reading more informative

* Corrected time reference

* Try shortening the response

* Revert attempt

* Updated templates and documentation

* Minor improvement in response when delta is 0

* German translations improved and added (nightscout#5360)

* Fix Alexa Launch and SessionEnded Requests (nightscout#5377)

* Fix Alexa Launch Request

* Allow LaunchRequest to handle intent if set, change shouldEndSession from string to bool

* Fix SessionEndedRequest

* Fix nightscout#5149 - discord link on CONTRIBUTING.md doesn't do anything (nightscout#5380)

* Fix nightscout#5146 - display of treatment with only Fat and Protein set (nightscout#5381)

* Basic report page style fixes and updates (nightscout#5387)

* Add missing Polish translations and improve existing (nightscout#5382)

* Add missing Polish translations and improve existing

* Improve translations

* Addressed virtual assistant usage with Authentication Roles (nightscout#5388)

* Fix nightscout#5347 - Addressed auth roles

* Unification

* Fix timeago alarms (again). The changes to the rendered had an unintended consequence of triggering the timeago detection less frequently, causing the code to think the client has been hibernating, thus suppressing the alarms. The update changes the clock to be updated more frequently (this updating the hibernation detection), fixing the issue

* Remove the server side test

* Fix Graph Display Without Recent Devicestatus (nightscout#5409)

* Update Russian (nightscout#5415)

Corrected major and minor misprints and mistakes - particularly in variables, new translations added

* Add server teardown ability (nightscout#5410)

* adding teardown event to ctx.bus

* adding teardown support for mmconnect and bridge plugins

* Additional German Translations and corrections (nightscout#5405)

* Cleaned up changed translations

* Added Virtual Assistant Translations

* Fix nightscout#5188 - move predictions to bundle and don't render chart on predictions offset change (nightscout#5395)

* Fix nightscout#5188 - move predictions to bundle and don't render chart on predictions offset change

* Fix predictions show for day to day

* Move toolbar and authentication status to partial and include on each page (nightscout#5393)

* Move authentication status to partial and include on each page

* Move toolbar to partial

Co-authored-by: Sulka Haro <[email protected]>

* Virtual assistant code simplification (nightscout#5400)

* Moved duplicate plugin code to single location, and small improvements

* Defined _each()

* Pr/5379 (nightscout#5441)

* Release 13.0.1 (nightscout#5329)

* Release ref update v2 (nightscout#5301)

* Updated release name and number

* Added missing version number

* Added missing version number

* Fix auth dialog sizing error (nightscout#5315)

* Fix auth dialog sizing error (nightscout#5314)

* Fix auth dialog sizing error

* Fix Client Init After Auth

(cherry picked from commit 1bf416c)

* update NS minor version

* Added handlers and translations for CGM info

* Defined translate()

* Fixed sensor state reference

* Improved wording for tx age response

* Improved wording for session duration response

* Updated documentation and templates

* Updated README.md TOC and a reference to it

* Added CGM battery info

* Added unit reference to CGM battery levels

* Added handlers and translations for CGM info

* Defined translate()

* Fixed sensor state reference

* Improved wording for tx age response

* Improved wording for session duration response

* Updated documentation and templates

* Updated README.md TOC and a reference to it

* Added CGM battery info

* Added unit reference to CGM battery levels

* Updated API reference in Google Home template

Co-authored-by: Caleb <[email protected]>

* Volunteer for Polish translations (nightscout#5396)

* Api3 output renderers (nightscout#5425)

* APIv3: adding framework for various output renderers

* APIv3: adding xml output renderer

* APIv3: adding csv output renderer

* APIv3: documenting supported output renderers

* APIv3: testing output renderers

* Restore glucose distribution test (nightscout#5434)

* Increase coverage of tests on units utility and clean up timeago test (nightscout#5435)

* Increase coverage of tests on units utility

* clean up timeago test

* Refactor to encapsulate duplicated settings logic (nightscout#5426)

* Encapsulate duplicate settings checks inside functions

* Simplify settings::isAlarmEventEnabled()

* Send coverage reports to Codacy (nightscout#5444)

* Send coverage reports to Codacy

* Action secrets may not be read from forks :(

* Let's see if this fixes the path & key passing

* Ok one more try for the Actions env

* Run tests and coverage separately

* Try increasing the admintools test runtime for Node 10

* Run tests only once

* Resolve unnecessary uses of eslint-ignore (nightscout#5436)

* Resolve unnecessary disabling of no-undef eslint rule

* Resolve unnecessary disabling of no-prototype-builtins eslint rule

* Resolve unnecessary disabling of no-unused-vars eslint rule

* Resolve unnecessary disabling of no-empty eslint rule

* Fix eslint errors and add npm script for eslint (nightscout#5427)

* re-enable auth check for device status routes

* Resolve eslint errors

* Add npm script for eslint

* Correct regex for express extension middleware and add tests for expected behaviour

* Resolve lint error in virtual assistant base

* Update index.js

* Update index.js

* Remove redundant checks on entry ID (nightscout#5440)

* Run CI Action for Pull Requests

* Update DayToDay report for Loop Overrides (nightscout#5452)

Add Loop override name/reason as text to the grey bar at the top of the graph.

* Fix earlier merge error with predictions having moved to the report bundle

* fix brushing loop (nightscout#5499)

* Update README.md (nightscout#5480)

Clarified that the "bridge" plugin is for Dexcom Share ("Dexcom" didn't appear at all in the read me), fixed a few typos, and added line 444 about the BRIDGE_SERVER variable.

* Added period of days into headline of glucose distribution and percen… (nightscout#5428)

* Added period of days into headline of glucose distribution and percentil chart report

I make screencopies of the glucose distribution and percential chart report for my diabtes consultant and had to manually add the period of days to the report everytime because it was not shown in the report itself.
I added the period of days this with a small number of lines of code and think this is helpful for other too.

* removed comments as requested

removed comments as requested

* Camelcase for new variables reportPlugins, firstDay, lastDay, countDays

* forget to save the change of reportPlugins in percentile.js

* Move app caching to a service worker (nightscout#5504)

* Move app caching to a webworker

* Code cleanup

* Code cleanup

* Make Codacy happy

* More parentheses

* Added indexes to 'entries' and 'treatments' along with other updates (nightscout#5463)

* Added compound indexes for treatments and entries collections. Updated ensureIndex to createIndex in mongo-strage.js as ensureIndex has been deprecated. Finally, updated testing/populate.js to be compatible with more recent versions of the node driver, as well as fixing a path issue.

* Fixed missing end quote in lib/server/treatments.js. Changed all newly added double quotes to single quote to match style guide.

* Removed indexes that referenced key600.

* Fix: Round interporlated mg/dL value to an integer

* Plugin to show database size (% of available space or in MiB) (nightscout#5496)

* Database size plugin - pill that displays current mongoDB database size

* Enabled dbsize by default

* Fixed bug with dbsize not shownig when size is (rounded) 0% but real bytes > 0

* Cleanup & update to iconfont generation manual

* Changed how warning/urgent levels are configured - from absolute MiB to percentage of DBSIZE_MAX

* Trying to fix random fail of APIv3 tests (nightscout#5519)

* APIv3: isolating documents from tests (not allowing clashes of calculated identifiers)

* removing unused async keyword

* client - mobile - Axis label font is scaled on small screens (nightscout#5512)

On phones or other small screens, the axis labels (especially x axis)
were previously an unreadable jumble of too-close letters

* Split view (nightscout#5518)

* Adds a 2, 3, 4 and 8 way split view option

* Updated description

* Generate the table on demand, so any number of sites from 1 to 8 generates a sensible layout

* Update readme & don't crash if a name is missing

* Allow flagging specific settings to be not exposed the /properties and /status APIs (nightscout#5525)

* Add more variables to the special list

* [DEV][FIX] Fix dbsize plugin to make it hideable again (nightscout#5529)

* [FIX] Making dbsize plugin default but hideable - removed its forced show state

* Removed unused lodash dependency

* Removed duplicate if statement (nightscout#5531)

Removed the additional if statement checking for the loop specific developer team id. This since the exact same if statement existed just above it.

* Update Dutch translations (nightscout#5532)

* Fix settings test

* Update version to 13.1.0

* Fix topbar collapse on small screens (nightscout#5562)

* Fix top bar collapsing on small screens

* Fix wide button array overflowing the button bar

* Option to switch off bolus amount outputs (nightscout#5522)

* Option to switch off bolus amount outputs (nightscout#5514)

* Fixing issue with carb value not be output when set to "none" (nightscout#5514)

* Adding additional output options (nightscout#5514)

* Adding environment variable option for 'x U and Over' option.

This option is BOLUS_RENDER_OVER with a default value of 1 and the value can be an integer or a float, e.g. 0.3, 1.5, 2, etc...

* Adding change to change the font size depending on the bolus value.

* Merge two "all" options to create an option that displays as SMB had.

* Fix d3 portrait to landscape brush failure (nightscout#5638)

* fix d3 portrait to landscape brush failure

* fix client.renderer.test for highlighBrushPoints function prototype change

* fix highlightBrush

* move brush reset inside check for valid brush

* Sanitize data from manual careportal entries so only fields with actual data are sent to the server (nightscout#5619)

* do not redirect to profile editor by default (nightscout#5671)

In a default configuration, there is no treatment data.  The code to redirect
the UI to the profile editor is buried deep within the chart rendering code for
basals.  This plugin is only supposed to go into action when enabled via
ENABLE=basal.  This commit fixes first-use experience for the default
configuration intended to draw real-time CGM traces and no basal information is
expected.  Since no basal information is expected unless plugin is enabled via
ENABLE=basal, this allows skipping instead of redirecting to the profile editor.

* Fix Issue nightscout#5486 - Device Status Days Feature (nightscout#5651)

* Device Status Days Feature

* Edits per review from @sulkaharo

* Configurable clock views (nightscout#5625)

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Configurable clock views

* Update README.md

* Update README.md

* Configurable clock views

* Add remote bolus/carbs + otp entry for loop (nightscout#5598)

Add a remote bolus entry field for users on Loop, along with support for an OTP field

* Sometimes at the very start no profiles provided. (nightscout#5591)

At the first start the nightscout is crashed if profile not full.

* Fixes nightscout#4991 - Now selects basal profile based day by day (nightscout#5572)

* Test profile settings

* NPM Version change

* Use console log

* Use console log for client

* Use console log for client.sbx

* Use console log for client.ddata

* Use console log for client again

* revert

* Added multi-profile reporting capabilities

Co-authored-by: VIS TFS Admin <[email protected]>

* prepare hotfix for MMConnect/EU - 2020-06-28

Prepare to handle issue nightscout#5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.

* bump pointing at right tag

* prepare hotfix for MMConnect/EU - 2020-06-28

Prepare to handle issue nightscout#5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.

* bump pointing at right tag

* hotfix attempt 2 - carelink 2020 sso updates

* hotfix 3 - attempt 3 at carelink 2020 sso updates

* attempt 4 at hotfix for nightscout

Based on more reliable version of minimed-connect-to-nightscout....
This is testing the hotfix.  When it works, we will bump this one more
time with the newly released version.

* hotfix 5 - incorporates latest axios changes

* Fix for boluscalc issue (nightscout#5729)

Boluscalc fix & remove integer validation from BG input field

* npm install --save minimed-connect-to-nightscout@^1.4.0

* Change DISPLAY_UNITS to use readENV's default value and added several tests for DISPLAY_UNITS (nightscout#5708)

readENV() was hard coding the default value of DISPLAY_UNITS, and
ignoring the default value for no particular reason. Fixed that. Also, I
added a full test suite for DISPLAY_UNITS environment settings to make
sure that it works as intended. Finally, I've added the console log for
the DISPLAY_UNITS since there's no particular reason why we log that setting
and not others.

* Fix audit errors, button order (nightscout#5694)

* * Update packages giving npm audit errors
* Fix Mongo test that broke after update (now uses async/await on getting the connection)
* Restore original navigation bar button order

* Disable Node 10 tests

* Fix temporary target cancellation

* Added documentation on the use of Alpha Testing (nightscout#5784)

* Wip/bewest/mmconnect eu (nightscout#5731)

* prepare hotfix for MMConnect/EU - 2020-06-28

Prepare to handle issue nightscout#5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.

* bump pointing at right tag

* hotfix attempt 2 - carelink 2020 sso updates

* hotfix 3 - attempt 3 at carelink 2020 sso updates

* attempt 4 at hotfix for nightscout

Based on more reliable version of minimed-connect-to-nightscout....
This is testing the hotfix.  When it works, we will bump this one more
time with the newly released version.

Co-authored-by: Sulka Haro <[email protected]>

* * Updated several packages to remove issues from NPM audit
* Fix excess logging in settings.js
* Removed heapdump package, which was causing issues for some users

* * Limit the default number of profiles returned by the API to fix issues with users who are syncing a large amount of profiles from an APS.
* Fix profile reporting

* Upgrade Helmet to 4.0.0

* CSP and service worker improvements (nightscout#5856)

* Add connectSrc for Safari compatibiity
* Add new font URL for Google Fonts compatibility
* Reload on re-registering the worker
* Change Mongo version in github to fix builds

* Serve the CSP to everyone

* Split view CSP support (nightscout#5864)

* Parse split view frames into frameAncestors

* Re-enable CSP configuration (nightscout#5867)

* Re-enable CSP configuration

* Bump share2nightscout-bridge plugin

Use latest update from share2nightscout bridge to
make things easier.  It contains an updated
default for OUS users.

* feat Add robots.txt to disallow site crawling

* Fix dbsize for usage with Atlas (nightscout#5962)

* Openaps performance improvement (nightscout#5945)

* improve openaps plugin performance

* more performance improvements

(cherry picked from commit 076a2dd)

* correct setting notEnacted variable

* remove unnecessary debug logging

* Adapt to MongoDB Atlas (nightscout#5893)

* Fix Issue nightscout#5763 - Change $.ajax to /api/v1/profile (nightscout#5704)

* Bug fixes for Service Worker (nightscout#5970)

* Fix service worker refresh for Firefox

* Improve logging for service worker initialisation

* Skip browser cache for service worker precaching

* Prevent `Partial Content` responses in `fetch` by stripping `Range` header

* Prevent calling `filter` on an undefined property when service worker cache is empty

* Bug fixes for Service Worker

*    Fixes nightscout#5920
*    Fixes nightscout#5943

* Update service-worker.js

Removed the MP3 files from the preload to fix issues with webkit-based browsers

Co-authored-by: p5nbTgip0r <[email protected]>
Co-authored-by: Sulka Haro <[email protected]>

* Optimize Nightscout database usage (nightscout#5947)

* On periodic polls, only load delta for CGM data, treatments and device statuses
* Serve basic CGM data API queries from in-memory cache. Increases the Nightscout memory footprint but should significantly reduce the Mongo load
* Serve device status, CGM and treatment records from memory cache
* Support count parameter in /profile

* Bumping version to 14.0.0 given this is a relatively large update and we want people on Atlas to all migrate to this version

* Remove logging statements

* fix brushing recursion

* Normalize treatments to support absolute doses from the amount field

* Add Loop Carbs foodType, absorptionTime to Reports for ISSUE nightscout#5701 (nightscout#5702)

* add carb foodType, absorptionTime to reports

* Update README to point to new docs

* Fix `Treatments` report for `mmol/L` users

Fixed a typo to a client function name

* Bump version to 14.0.1

* Bump dev to 14.0.2

* Serve Last-Modified header for the service worker to help with some browsers misdetecting caching

* Cleaned old appcache references

* * Remove unnecessary logging to help with Papertrail limits
* Load more treatments and entries to fix caching issues (need to add better cache invalidation to really fix this)

* When merging inserts and updates from the database, ensure we always use the new data over the old data

* Bump treatment delta loading to four hours

* One more increase to treatment load time to cover long overrides

* * Bump version to 14.0.3
* Fix a bug in the REST API query for profiles

* Bumped up the number of treatments loaded / day for reporting

* Fix reports unit test

* Bump treatments default limit default to 1000 objects for queries that include other query parameters

* * Require created_at for Treatments on insert
* Refactoring the cache: moved to another file and support flushing from bus events

* Add support for CGM data and device statuses. Refactor dataloader to use the new model and reduce queries back down

* Fix data order for REST API

* * Add cache update events to websocket API
* Remove the validation for created_at in REST API ;(

* Remove excess logging

* Bump version to .4

* Bump version to 14.0.5 and fix nightscout#6050

* Fix Pebble API detecting mmol units from settings

* Make settings parsing whitespace tolerant

* * Fix security test
* Change boot and caching to expose Mongo connection errors

* Don't report an error on every reconnect

* Less intimidating error page on start, which also checks for api_secret

* Add file missing from last commit

* Fix tests

* Remove require statement breaking deploys

* Update --feature-request--.md

* Update --bug-report.md

* Update --individual-troubleshooting-help.md

* Fix memory leak and cache update issues in 14.0.4 (nightscout#6133)

* Fix a memory leak in 14.0.4
* Fix linter error in ddata.js
* Move data retention periods to caching
* Update _id of inserted entries and device status so merging to cache works correctly
* Reset the data in ddata before updating
* Fix typo on entry cache retention period
* Have device status cache retention period follow configuration
* Fix _id injection in treatments

* Add error cat to error page

* Fix MONGODB_URI reference in error message

* Bump version to 14.0.6

* Support uploading device statuses in batches (nightscout#6147)

* Support uploading device statuses in batches
* Correctly report batch insertion results

* Make empty cache detection a bit more aggressive to account for cache flush and data insert happening concurrently

* * Bump version to 14.0.7
* Add onerror handler for pushover

* Update README.md

Explicitly link to the application template in Github

* Fixed nightscout#5852 - Updated Google Home setup steps (nightscout#6195)

* Fix broken swagger for APIv3 (nightscout#6201)

* APIv3: isolating documents from tests (not allowing clashes of calculated identifiers)

* removing unused async keyword

* fixing api v3 swagger and moving it to /api3-docs

Co-authored-by: Petr Ondrusek <[email protected]>
Co-authored-by: Petr Ondrůšek <[email protected]>

* Use lodash.get() in virtual assistant API endpoints (v2) (nightscout#6199)

* Fixed nightscout#5632 - Improved value resolution

* More value resolution improvements

* Fixed a couple object paths

* Corrected setup of `dbsize` for virtual assistants (nightscout#6270)

* Corrected db size config for virtual assistants

* Language fix, improvements, added dbsize to virtAsst config

* Using env

* Added logging

* Debug logging

* Different logging

* More troubleshooting

* Another try

* Reverted stuff, added dbsize to server defaults

* Fixed test

* Fixed another test

* Create config.yml

* Delete --individual-troubleshooting-help.md

* Update config.yml

* Fix batch (nightscout#6248)

* Use the delta plugin data to show the delta in the clock views
* Update Node checks
* Fix disabling the BG alarms for simple alarms
* Load battery and other rare events up to two months back
* Possibly fixes compatibility with ios9 - needs testing
* Unified black and color clock layouts
* Update clock data every 20 seconds
* Update clock time every second
* Fix how CSP policy is set for Helmet, fixes nightscout#6260
* Authorization fix for misformatted URLs
* Added unit test for batch upload of CGM entries
* Improved / removed some logging
* Test if user is in read only mode when Nightscout starts and give an error if so

* Adding Hungarian translation to nightscout (nightscout#6037)


* Finished first round of translation for Hungarian language

* Added hungarian language to the readme file

* Fixes

* WIP

* Typo fixes and changes to translations

* Update language.js

Fixed some mistyped language keys

Co-authored-by: Andy Feher <[email protected]>
Co-authored-by: Sulka Haro <[email protected]>

* Update language.js (nightscout#6193)

Isfjell -> Istapp

Co-authored-by: Sulka Haro <[email protected]>

* nightscout#5991 Typo in translation (nightscout#6217)

Co-authored-by: Sulka Haro <[email protected]>

* add missing translations (nightscout#6346)

Co-authored-by: Sulka Haro <[email protected]>

* Updated Alexa's intents because Amazon required new ones yet again. (nightscout#6457)

* Add runtime state tracking to Nightscout, where client now checks if the server has loaded initial data from Mongo before the user is directed to the UI

* Add file missing from previous commit

* Update app.json

* Fix unit tests

* Fix the read detection to work correctly with MongoDB Atlas

* * Added basal and careportal to default plugins
* Changed report BG target to allow fractional numbers

* Increase load interval to 5 seconds

* Create codeql-analysis.yml

Co-authored-by: AdrianLxM <[email protected]>
Co-authored-by: Caleb <[email protected]>
Co-authored-by: inventor96 <[email protected]>
Co-authored-by: Jeremy Cunningham <[email protected]>
Co-authored-by: Sulka Haro <[email protected]>
Co-authored-by: Tanja <[email protected]>
Co-authored-by: Bartłomiej Szubert <[email protected]>
Co-authored-by: Andrew Dixon <[email protected]>
Co-authored-by: fedor apanasenko <[email protected]>
Co-authored-by: Petr Ondrusek <[email protected]>
Co-authored-by: Lukas Herzog <[email protected]>
Co-authored-by: Jakob <[email protected]>
Co-authored-by: jonfawcett <[email protected]>
Co-authored-by: Jonas Hummelstrand <[email protected]>
Co-authored-by: peterleimbach <[email protected]>
Co-authored-by: Adam Harrison <[email protected]>
Co-authored-by: Dominik Dzienia <[email protected]>
Co-authored-by: stephencmorton <[email protected]>
Co-authored-by: Simon Persson <[email protected]>
Co-authored-by: Cas Eliëns <[email protected]>
Co-authored-by: Ben West <[email protected]>
Co-authored-by: Matthew <[email protected]>
Co-authored-by: ireneusz-ptak <[email protected]>
Co-authored-by: josep1972 <[email protected]>
Co-authored-by: Bluefox <[email protected]>
Co-authored-by: fromorbonia <[email protected]>
Co-authored-by: VIS TFS Admin <[email protected]>
Co-authored-by: joracine <[email protected]>
Co-authored-by: Alexandre Viau <[email protected]>
Co-authored-by: Lennart Goedhart <[email protected]>
Co-authored-by: p5nbTgip0r <[email protected]>
Co-authored-by: Jeremy Cunningham <[email protected]>
Co-authored-by: kskandispersonal <[email protected]>
Co-authored-by: Petr Ondrusek <[email protected]>
Co-authored-by: Petr Ondrůšek <[email protected]>
Co-authored-by: Andras Feher <[email protected]>
Co-authored-by: Andy Feher <[email protected]>
Co-authored-by: bjornoleh <[email protected]>
Co-authored-by: Matt Gaide <[email protected]>
Co-authored-by: Lukas Herzog <[email protected]>
@maskac
Copy link

maskac commented Jan 13, 2021

I have about ten people on carelink. Even though I use version 14.1.0 of NS I still get 403 error (forbidden). Have any idea what can i do now ?

@jhuang234
Copy link

I have about ten people on carelink. Even though I use version 14.1.0 of NS I still get 403 error (forbidden). Have any idea what can i do now ?

Hi maskac,

I tried last night and get 403 error, too. Currently I moved the mmconnect plugin to another PC with ubuntu and run as a standalone service, so that Medtronic cannot ban mmconnect from heroku.
Please see wrapper by FredMK:
https://github.com/FredMK/minimed-connect-to-nightscout-wrapper

Hope it help.

@maskac
Copy link

maskac commented Jan 15, 2021

I tried last night and get 403 error, too. Currently I moved the mmconnect plugin to another PC with ubuntu and run as a standalone service, so that Medtronic cannot ban mmconnect from heroku.
Please see wrapper by FredMK:
https://github.com/FredMK/minimed-connect-to-nightscout-wrapper

Hope it help.

I have free hosting NS for more than ten parents witch carelink (and hundrer others), this solution use only same who are able to install node, etc but there are not many of them.

@psonnera
Copy link

Same seen with ns.10be. I guess everybody with this issue needs to remove mmconnect from ENABLE for the moment. Maybe we can get a simple project with Raspberries for those without a.computer?

@TwistaTim
Copy link
Member

Hi team, this issue is now fixed in #6687 , it requires a redeploy of your heroku instance (or change of IP address for the dyno).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests