Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link on report #4059

Closed
whooze opened this issue Nov 8, 2018 · 4 comments
Closed

Broken link on report #4059

whooze opened this issue Nov 8, 2018 · 4 comments

Comments

@whooze
Copy link
Contributor

whooze commented Nov 8, 2018

The link http://www.healthline.com/diabetesmine/a-new-view-of-glycemic-variability-how-long-is-your-line#2 is broken.

Can be found on /report the Distribution-tab

Screenshots

image

Your setup information
Should be the same problem on earlier versions too

@nealgriffin
Copy link

Hi there - I'm actually interested in helping out on this repository and this is a pretty straightforward change - I'll submit the required PR to the maintainers, but wanted to ask if there was / should be a different link referenced here, if so can you paste the link needed? Thanks

@PieterGit
Copy link
Contributor

@whooze @nealgriffin I already fixed this with #4052

@sulkaharo suggested to use this link https://www.ncbi.nlm.nih.gov/pmc/articles/PMC5467104/
I think the healtline article is easier readable, but of course the ncbi article is more scientific approach.

@nealgriffin If you want to PR a change that includes both links, please do.

@nealgriffin
Copy link

@PieterGit beauty! I'll do that - let me get myself setup - thnks

@PieterGit PieterGit added this to the 0.11.0 milestone Nov 16, 2018
@PieterGit
Copy link
Contributor

@nealgriffin Are you still interested in fixing/improving this PR? This is a nice beginner task to improve the docs in the code. If you need help, please visit https://gitter.im/nightscout/public
Postponing to 0.12.x release for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants