New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java findbugs - nullcheck of value previously dereferenced #102

Open

GoogleCodeExporter opened this issue Jan 7, 2016 · 1 comment

Labels

auto-migrated Priority-Medium Type-Defect

GoogleCodeExporter commented Jan 7, 2016

The code does not run cleanly though FindBugs because of some bugs:

In org/poly2tri/triangulation/delaunay/sweep/DTSweep.java at lines 634, 789, 
the 'if(ot == null)' checks are made after 'ot' is dereferenced. This condition 
can never be true because a NullPointerException would be thrown on the lines 
before.

Original issue reported on code.google.com by [email protected] on 21 Jan 2015 at 12:03

The text was updated successfully, but these errors were encountered:

Author

GoogleCodeExporter commented Jan 7, 2016

Yeah those two ot=null checks can be removed. I kept them just to be a reminder 
of where I had to add code if I wanted to include the filling of missing 
triangles during the constrained edge phase. Now the filling is done separately 
before the edge phase.

I should have commented out those ot=null tests when keeping them as a reminder.

Original comment by [email protected] on 21 Jan 2015 at 1:21

GoogleCodeExporter added Priority-Medium auto-migrated Type-Defect labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment