Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background location permission on Android 10 #9

Closed
leso-kn opened this issue May 20, 2020 · 8 comments
Closed

Background location permission on Android 10 #9

leso-kn opened this issue May 20, 2020 · 8 comments

Comments

@leso-kn
Copy link

leso-kn commented May 20, 2020

Android 10 introduced a new 'background location' permission.

As mentioned here UnifiedNlp needs to request this permission in order to function propperly.

Being a very simple fix i would love to see it in Microg Installer Revived :)


To fix it add

<uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION"/>

to the AndroidManifest.xml of GmsCore.

There's also a open pull request on microg that does exactly that.

@leso-kn leso-kn changed the title Background location permission in Android 10 Background location permission on Android 10 May 20, 2020
@nift4
Copy link
Owner

nift4 commented May 20, 2020

Hi. Thanks for using my module :)
Sadly I don't understand what do you want. microG Installer Revived uses the offical prebuilt APKs and I can't simply change the AndroidManifest of that apk. Is your suggestion to include an APK of an fork with it fixed?

@leso-kn
Copy link
Author

leso-kn commented May 20, 2020

Hi! :)
I see. Sorry, I was not sure if the official or a custom apk is bundled with the package.

I've read that the developer of microG recently stated he would pick up the work on it soon. But that's already some time ago again.

If including an apk of a fork is an option I can check if I find one that works. Since there's no updates to the official apk right now it might be worth including a fixed version for the time being. What do you think?

@nift4
Copy link
Owner

nift4 commented May 20, 2020

I agree. When you find an fork with it fixed and an apk I change it. I would be happier if you change it via a pull request through, you only need to swapout apk. I already added the permission in the other (module) xml as it's needed anyway

@nift4
Copy link
Owner

nift4 commented May 20, 2020

Nice, I wait for the apk or pull request :) (In meantime I work on Play Store)

@nift4
Copy link
Owner

nift4 commented May 20, 2020

Hi again; would it be for you possible to test something? (#10)

@leso-kn
Copy link
Author

leso-kn commented May 20, 2020

Well, I decided to use the fork of @eplinux as it already contains the fixes for both GmsCore and UnifiedNlp.
After taking a break of some time I am currently fighting with serval docker setups in order to compile the repo; the gradle files seem to be a bit outdated.

Once that is running it should be no problem to test it :)

@leso-kn
Copy link
Author

leso-kn commented May 20, 2020

I already thought about just de- and recompiling the official apk with apktool.
But this would be a rather dirty solution. I might re-consider it for testing in case fixing the gradle stuff takes very long.

@nift4
Copy link
Owner

nift4 commented Jun 1, 2020

From module site this is fixed and UnifiedNlp 2.0 is worked on, so ig I can close this

@nift4 nift4 closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants