Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Aggregators Support #846

Open
SAMJN opened this issue Dec 29, 2017 · 7 comments
Open

Multiple Aggregators Support #846

SAMJN opened this issue Dec 29, 2017 · 7 comments

Comments

@SAMJN
Copy link

SAMJN commented Dec 29, 2017

Hi All,

PivotTableMultiMetric In the file pivot.js attached in this repository, you can refer for multiple metrics support of Pivot Table. Kindly start watching the repository, I will update the library with my work of heatmap and subtotals soon. Gave the link of this issue in #684 too.

@nicolaskruchten , would love to here your remarks on work.

@nicolaskruchten
Copy link
Owner

It's an interesting approach for sure, nice work!

My main feedback is around the lack of generality: this supports hardcoded multi_X(a, b) where X is Sum or Average etc, so it doesn't allow for Sum(a) and Average(b) and newAggregator(c) side by side, say. My feeling is that this second use-case is more common, and that users will find this limitation difficult to deal with.

On a second note, it's not clear how to support multiple aggregators within the chart renderers, which breaks the symmetry of the library a bit.

If we're able to resolve these issues I would happily consider integration into the main library but over the past couple of years of thinking about it I haven't found a solution for these issues that I'm happy with yet.

@SAMJN
Copy link
Author

SAMJN commented Jan 10, 2018

Thanks for the review.

On the point of supporting, Sum / Average and newAggregator (like setup) side by side is not supported yet. I will start looking into it.

The part with multiple aggregator support in Chart renderer. I am currently working on it and will give updated C3 renderer file as soon as possible.

@statico
Copy link

statico commented May 17, 2018

@SAMJN Very nice. I would love to use this as a plugin instead of a fork of the main project.

@smith01s
Copy link

@SAMJN & @nicolaskruchten I too would be very interested in having multiple aggregators available to me. Is this on the road map for future implementation?

@nicolaskruchten
Copy link
Owner

I'm not currently working on this, and the UX for properly supporting it seems to me to be very complex so I am not expecting this to be supported in the medium term either.

@SAMJN
Copy link
Author

SAMJN commented Jun 5, 2018

@smith01s, I was working on different aggregators for different metrics. But I agree with @nicolaskruchten, it requires a lot of complex changes. I am also not able to find any viable solution for same.

My solution is - > club all the aggregators in one. And based on any condition, switch between the different aggregators.

@BBBhatt
Copy link

BBBhatt commented Aug 11, 2021

I just want to format numbers without decimal places..
what options should i Use with it?

-Thanks,
Bhavin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants