Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Edge Case - Next project not created and init command working. #187

Open
DhairyaMajmudar opened this issue Apr 24, 2024 · 0 comments · May be fixed by #188
Open

Bug: Edge Case - Next project not created and init command working. #187

DhairyaMajmudar opened this issue Apr 24, 2024 · 0 comments · May be fixed by #188
Assignees
@nicoalbanese
Labels
bug Something isn't working

Comments

@DhairyaMajmudar
Copy link

Describe the bug
command kirimase init is still running even if a folder has basic package.json file and app folder within it.

To Reproduce
Steps to reproduce the behavior:

  1. Create an empty folder
  2. initialise package.json file using command npm init
  3. create app folder within
  4. Now run the coammnd kirimase init

Expected behavior
command should exit execution while throwing the msg. " No Next.js project detected. Please create a Next.js project and then run kirimase init within that directory. "

Screenshots
image

Desktop (please complete the following information):

  • OS: Linux ( Debian )
  • Browser Firefox
  • Version Latest

Additional context
This can be prevented by adding more checks in the line 13 of file src/commands/init/index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicoalbanese nicoalbanese

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Changing Conditions for nextjsProjectExists DhairyaMajmudar/kirimase-cli
2 participants
@nicoalbanese @DhairyaMajmudar