Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the command #9

Open
Josh00-Lu opened this issue Dec 6, 2024 · 3 comments
Open

Question about the command #9

Josh00-Lu opened this issue Dec 6, 2024 · 3 comments

Comments

@Josh00-Lu
Copy link

Josh00-Lu commented Dec 6, 2024

Congratulations on this excellent work!

Are the command "c_x", "c_y" and "c_yaw" randomly sampled in each episode? Do they change in each episode? And is there a "max truncation timestep" (e.g. 1000) in your settings?

Besides, is there a typo in Table 2. (T13) in the Appendix? There seems to be an extra negative sign here.

Thank you very much.

@Josh00-Lu Josh00-Lu reopened this Dec 6, 2024
@Josh00-Lu Josh00-Lu changed the title Question about the PD controller Question about the PD controller & Command Dec 6, 2024
@Josh00-Lu Josh00-Lu changed the title Question about the PD controller & Command Question about the command "c_x", "c_y" and "c_yaw" Dec 6, 2024
@Josh00-Lu Josh00-Lu changed the title Question about the command "c_x", "c_y" and "c_yaw" Question about the command Dec 6, 2024
@nico-bohlinger
Copy link
Owner

Hey!

Yes, new command velocities are sampled with probability 0.002 every step, i.e. on average every 10 seconds.
An episode lasts for 20 seconds, which means at 50Hz action frequency this is 1000 environment steps.

You are correct, the minus in front of the sum is wrong. Thank you for noticing it!

@Josh00-Lu
Copy link
Author

Josh00-Lu commented Dec 8, 2024

Hey!

Yes, new command velocities are sampled with probability 0.002 every step, i.e. on average every 10 seconds. An episode lasts for 20 seconds, which means at 50Hz action frequency this is 1000 environment steps.

You are correct, the minus in front of the sum is wrong. Thank you for noticing it!

Thank you very much! If my understanding is correct, will the new command velocities change (but at most once) during one episode? And will the command counter (10 sec, as you mentioned) reset when an episode is terminated or truncated?

@nico-bohlinger
Copy link
Owner

There is no counter for the command velocity change. At every step a boolean for changing the command velocity is sampled, like (pseudo code):
should_change_command = random.float(0, 1) < 0.002
if should_change_command: command_velocity = sample_command_velocity()

This means potentially the command velocity could even change 1000 times per episode, i.e. in every step. But with the probability of 0.002 it happens on average every 500 steps, so on average every 10 seconds. This still means it can happen more or less often and as I said there is no counter so it's also not affected by episode resets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants