Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace request lib? #204

Open
cktang88 opened this issue Dec 25, 2018 · 9 comments · May be fixed by #275
Open

Replace request lib? #204

cktang88 opened this issue Dec 25, 2018 · 9 comments · May be fixed by #275

Comments

@cktang88
Copy link

Request is really bloated, and since it seems to only be used here to make a simple POST request, we can easily replace it with something lighter like got or axios. See https://bundlephobia.com/[email protected]

@seangenabe
Copy link

seangenabe commented May 5, 2019

It is a really simple POST request; I think it can be easily replaced with just a call to require('https').request. request is really bloated and I'd like to see fewer utility packages such as this one using it. It includes a lot of unnecessary stuff to do just a simple call. Additionally I'm getting unnecessary security alerts from request.

Re: #200 #191 we'll have a lot less of these without request

@XhmikosR
Copy link
Contributor

You could make a PR suggesting this change :)

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 13, 2019

BTW https://packagephobia.now.sh/result?p=coveralls and https://packagephobia.now.sh/result?p=request which means request accounts for most of coveralls' size (~92.7%). IMO this is something that should be definitely looked into pretty soon.

@cktang88
Copy link
Author

@nickmerwin thoughts?

@XhmikosR
Copy link
Contributor

Someone should submit a patch. We should definitely do this. Ideally without a lib, but if it's too many changes, we could try using one of the many lightweight alternatives.

Feel free to ping me when you have a PR.

@jaeh
Copy link

jaeh commented Feb 13, 2020

request 2.88.2 is the last version that will be released,

see:
request/request#3142

i can replace the request lib with the native http module,
the code makes it look very straightforward,
just want to make sure nobody else works on this and that i do not miss anything.

@jaeh jaeh linked a pull request Feb 13, 2020 that will close this issue
@guimard
Copy link
Contributor

guimard commented Jun 1, 2020

Hi, note also that request has been deprecated

@jimmywarting
Copy link

jimmywarting commented Sep 2, 2020

+1 for require('https').request if it's just one simple post request.
looking into ways to reduce my sub dependencies - thats why i'm here

@jtwebman
Copy link

jtwebman commented Mar 6, 2022

Since this library doesn't seem to be supported anymore I fix a bunch of things on a fork if you want to check it out and are still pulling the library into your packages: https://github.com/jtwebman/coveralls-next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants