-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace request
lib?
#204
Comments
It is a really simple POST request; I think it can be easily replaced with just a call to Re: #200 #191 we'll have a lot less of these without |
You could make a PR suggesting this change :) |
BTW https://packagephobia.now.sh/result?p=coveralls and https://packagephobia.now.sh/result?p=request which means request accounts for most of coveralls' size (~92.7%). IMO this is something that should be definitely looked into pretty soon. |
@nickmerwin thoughts? |
Someone should submit a patch. We should definitely do this. Ideally without a lib, but if it's too many changes, we could try using one of the many lightweight alternatives. Feel free to ping me when you have a PR. |
request 2.88.2 is the last version that will be released, see: i can replace the request lib with the native http module, |
Hi, note also that |
+1 for |
Since this library doesn't seem to be supported anymore I fix a bunch of things on a fork if you want to check it out and are still pulling the library into your packages: https://github.com/jtwebman/coveralls-next |
Request is really bloated, and since it seems to only be used here to make a simple POST request, we can easily replace it with something lighter like got or axios. See https://bundlephobia.com/[email protected]
The text was updated successfully, but these errors were encountered: