Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numberFormatting description doesn't mention case #1909

Open
jrose-signal opened this issue Oct 21, 2024 · 0 comments
Open

numberFormatting description doesn't mention case #1909

jrose-signal opened this issue Oct 21, 2024 · 0 comments

Comments

@jrose-signal
Copy link

In lint mode, I got the following warning:

Use consistent grouping for numeric literals. Groups will be separated by _ delimiters to improve readability. For each numeric type you can specify a group size (the number of digits in each group) and a threshold (the minimum number of digits in a number before grouping is applied). (numberFormatting)

But looking at the line, there wasn't any grouping to be had:

let contrivedExample: [UInt8] = [0x52, 0xb8, 0x99, 0xef]

It turns out it was complaining about using lowercase hex instead of uppercase (a non-lint run made the change for me). That's fine, it still fits the category of "numberFormatting", but the description should say so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant