Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while transitioning to in-repo-engines #140

Closed
imnkr opened this issue Jun 20, 2019 · 2 comments
Closed

Error while transitioning to in-repo-engines #140

imnkr opened this issue Jun 20, 2019 · 2 comments

Comments

@imnkr
Copy link

imnkr commented Jun 20, 2019

While updating the ember version from 3.4.3 to 3.8.2 (ember-prefetch v3.1.0).
When trying to transition to routes in in-repo-engines for the very first time, the error route.prefetch is not a function is thrown even if the prefetch hook is not used in those routes.

I have reproduced the issue here

@jackson-dean
Copy link
Contributor

I had this same error. I created this PR https://github.com/nickiaconis/ember-prefetch/pull/150/files
Let's see if it is accepted.

@nickiaconis
Copy link
Owner

It sounds like #150 was replaced by #159, which has already been merged and released. Closing this as that PR should have resolved the issue, but please reopen if we've missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants