GN-149 Skip x route #157
Merged
GN-149 Skip x route #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… closing dropdown
Co-authored-by: w@rren <[email protected]>
wa-rren-dev
approved these changes
Nov 26, 2021
kavithanice
pushed a commit
that referenced
this pull request
Dec 2, 2021
* GN-95 Move NavLinks to own component * GN-95 Get button in if dropdown * GN-95 Skip links and click behaviour * GN-95 Skip links * GN-95 Styling * GN-95 Styling, aria controls, chevron * GN-95 Active text on button * GN-95 Refactoring styling * Ignore netlify file * GN-95 Chevrons and revised services list * GN-95 Link styling * GN-95 More services dropdown and styling * GN-95 Missed commit with dropdownComponent * Comment out test to get build * Attempt fix for $RefreshReg$ issue See https://github.com/pmmmwh/react-refresh-webpack-plugin/blob/main/docs/TROUBLESHOOTING.md#usage-with-indirection-like-workers-and-js-templates * Focus trap plugin * GN-95 Focus trap around all of nav when active * Remove tests for alpha * GN-95 Focus trap no initial focus * GN-95 Z-index for pathways and guidance fix * GN-95 Escape by clicking search or acccount * GN-95 Replacing with nds components * GN-95 Config fix for grid css issue * GN-101 Issues (#122) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> Co-authored-by: w@rren <[email protected]> * GN-102 Bnf content (#125) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> * GN-102 Nitpicking css * GN-102 Pull url from services * GN-102 Spacing * GN-101 Fix failing tests * GN-102 Update snapshot * GN-102 Fix letters and dancing button Co-authored-by: w@rren <[email protected]> * GN-103 Bnfc content (#126) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-103 BNFC content * GN-103 Revert nav text to abbreviation * GN-103 Use var for url * GN-103 Spacing * GN-101 Fix failing tests * GN-103 Update snapshot * GN-103 Button fix and letter link fix * GN-103 Button dancing fix * GN-103 Another dancing button fix attempt Co-authored-by: w@rren <[email protected]> * GN-105 Standards and indicators content (#128) * GN-105 Content for standards and indicators * GN-105 Update links * GN-105 Remove standards and indicators from more * GN-101 Fix failing tests * GN-105 Update snapshot * GN-105 Amend S&I base link Co-authored-by: w@rren <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-106 About us content (#130) * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-98 Content update * GN-106 About us content * GN-101 Fix failing tests * GN-106 Update snapshot * GN-98 Snapshot updated * GN-106 Content link issue * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-106 About us content update * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Prettier * Reset root about us URL Co-authored-by: w@rren <[email protected]> Co-authored-by: John Davey <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-98 Guidance content (#129) * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-98 Content update * GN-101 Fix failing tests * GN-98 Snapshot updated * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Url updates * Prettier Co-authored-by: w@rren <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-104 Cks content (#127) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-103 BNFC content * GN-104 CKS content * GN-104 Revert nav text to abbreviation * GN-103 Revert nav text to abbreviation * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> * GN-102 Nitpicking css * GN-104 Rename var * GN-102 Pull url from services * GN-103 Use var for url * GN-98 Content update * demo stuff * GN-104 Url var * GN-102 Spacing * GN-103 Spacing * GN-105 Content for standards and indicators * GN-106 About us content * GN-105 Update links * GN-105 Remove standards and indicators from more * GN-101 Fix failing tests * GN-102 Update snapshot * GN-103 Update snapshot * GN-105 Update snapshot * GN-106 Update snapshot * GN-104 Update snapshot * GN-98 Snapshot updated * GN-000 Alpha services. May want renaming for UR. * GN-000 Renamed for UR. DO NOT DEPLOY TO LIVE. * GN-000 Snapshot updated * GN-000 Links for UR. DO NOT DEPLOY TO LIVE * GN-000 Prettier issue * GN-102 Fix letters and dancing button * GN-103 Button fix and letter link fix * GN-103 Button dancing fix * GN-103 Another dancing button fix attempt * GN-106 Content link issue * GN-105 Amend S&I base link * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-106 About us content update * GN-109 More content * GN-107 Pathways content * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Duplicate css removed * Remove duplicate CSS * Remove duplicate css * Remove duplicate export * Links to live * Tidy up * GN-104 Snapshot update * Snapshot update Co-authored-by: w@rren <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-109 More dropdown content (#133) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-103 BNFC content * GN-104 CKS content * GN-104 Revert nav text to abbreviation * GN-103 Revert nav text to abbreviation * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> * GN-102 Nitpicking css * GN-104 Rename var * GN-102 Pull url from services * GN-103 Use var for url * GN-98 Content update * demo stuff * GN-104 Url var * GN-102 Spacing * GN-103 Spacing * GN-105 Content for standards and indicators * GN-106 About us content * GN-105 Update links * GN-105 Remove standards and indicators from more * GN-101 Fix failing tests * GN-102 Update snapshot * GN-103 Update snapshot * GN-105 Update snapshot * GN-106 Update snapshot * GN-104 Update snapshot * GN-98 Snapshot updated * GN-000 Alpha services. May want renaming for UR. * GN-000 Renamed for UR. DO NOT DEPLOY TO LIVE. * GN-000 Snapshot updated * GN-000 Links for UR. DO NOT DEPLOY TO LIVE * GN-000 Prettier issue * GN-102 Fix letters and dancing button * GN-103 Button fix and letter link fix * GN-103 Button dancing fix * GN-103 Another dancing button fix attempt * GN-106 Content link issue * GN-105 Amend S&I base link * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-106 About us content update * GN-109 More content * GN-107 Pathways content * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Duplicate css removed * Remove duplicate CSS * Remove duplicate css * Remove duplicate export * Links to live * Tidy up * Snapshot update Co-authored-by: Eleanor Mollett <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-110 Life sciences content (#137) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-103 BNFC content * GN-104 CKS content * GN-104 Revert nav text to abbreviation * GN-103 Revert nav text to abbreviation * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> * GN-102 Nitpicking css * GN-104 Rename var * GN-102 Pull url from services * GN-103 Use var for url * GN-98 Content update * demo stuff * GN-104 Url var * GN-102 Spacing * GN-103 Spacing * GN-105 Content for standards and indicators * GN-106 About us content * GN-105 Update links * GN-105 Remove standards and indicators from more * GN-101 Fix failing tests * GN-102 Update snapshot * GN-103 Update snapshot * GN-105 Update snapshot * GN-106 Update snapshot * GN-104 Update snapshot * GN-98 Snapshot updated * GN-000 Alpha services. May want renaming for UR. * GN-000 Renamed for UR. DO NOT DEPLOY TO LIVE. * GN-000 Snapshot updated * GN-000 Links for UR. DO NOT DEPLOY TO LIVE * GN-000 Prettier issue * GN-102 Fix letters and dancing button * GN-103 Button fix and letter link fix * GN-103 Button dancing fix * GN-103 Another dancing button fix attempt * GN-106 Content link issue * GN-105 Amend S&I base link * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-106 About us content update * GN-109 More content * GN-107 Pathways content * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Duplicate css removed * Remove duplicate CSS * Remove duplicate css * Remove duplicate export * Links to live * Tidy up * GN-110 Life Sciences dropdown content * Snapshot update Co-authored-by: Eleanor Mollett <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-107 Pathways content (#134) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-103 BNFC content * GN-104 CKS content * GN-104 Revert nav text to abbreviation * GN-103 Revert nav text to abbreviation * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> * GN-102 Nitpicking css * GN-104 Rename var * GN-102 Pull url from services * GN-103 Use var for url * GN-98 Content update * demo stuff * GN-104 Url var * GN-102 Spacing * GN-103 Spacing * GN-105 Content for standards and indicators * GN-106 About us content * GN-105 Update links * GN-105 Remove standards and indicators from more * GN-101 Fix failing tests * GN-102 Update snapshot * GN-103 Update snapshot * GN-105 Update snapshot * GN-106 Update snapshot * GN-104 Update snapshot * GN-98 Snapshot updated * GN-000 Alpha services. May want renaming for UR. * GN-000 Renamed for UR. DO NOT DEPLOY TO LIVE. * GN-000 Snapshot updated * GN-000 Links for UR. DO NOT DEPLOY TO LIVE * GN-000 Prettier issue * GN-102 Fix letters and dancing button * GN-103 Button fix and letter link fix * GN-103 Button dancing fix * GN-103 Another dancing button fix attempt * GN-106 Content link issue * GN-105 Amend S&I base link * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-106 About us content update * GN-109 More content * GN-107 Pathways content * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Duplicate css removed * Remove duplicate CSS * Remove duplicate css * Remove duplicate export * Links to live * Tidy up * Snapshot update Co-authored-by: Eleanor Mollett <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-000 All content (#132) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-103 BNFC content * GN-104 CKS content * GN-104 Revert nav text to abbreviation * GN-103 Revert nav text to abbreviation * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> * GN-102 Nitpicking css * GN-104 Rename var * GN-102 Pull url from services * GN-103 Use var for url * GN-98 Content update * demo stuff * GN-104 Url var * GN-102 Spacing * GN-103 Spacing * GN-105 Content for standards and indicators * GN-106 About us content * GN-105 Update links * GN-105 Remove standards and indicators from more * GN-101 Fix failing tests * GN-102 Update snapshot * GN-103 Update snapshot * GN-105 Update snapshot * GN-106 Update snapshot * GN-104 Update snapshot * GN-98 Snapshot updated * GN-000 Alpha services. May want renaming for UR. * GN-000 Renamed for UR. DO NOT DEPLOY TO LIVE. * GN-000 Snapshot updated * GN-000 Links for UR. DO NOT DEPLOY TO LIVE * GN-000 Prettier issue * GN-102 Fix letters and dancing button * GN-103 Button fix and letter link fix * GN-103 Button dancing fix * GN-103 Another dancing button fix attempt * GN-106 Content link issue * GN-105 Amend S&I base link * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-106 About us content update * GN-109 More content * GN-107 Pathways content * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Duplicate css removed * Remove duplicate CSS * Remove duplicate css * Remove duplicate export * Links to live * Tidy up * GN-110 Life Sciences dropdown content * Snapshot update Co-authored-by: w@rren <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-108 Snag list (#138) * Scrim * GN-101 Move focus to search when clicked * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Close MyAccount Dropdown on meganav click * GN-101 Styling issues across applications * GN-101 Use bundled design system css * GN-101 Loose grid * GN-98 Initial guidance content * GN-95 Now click scrim to close * GN-101 Fix list styling variation * GN-102 Add BNF content * GN-102 BNFc content * GN-102 BNF content update * GN-103 BNFC content * GN-104 CKS content * GN-104 Revert nav text to abbreviation * GN-103 Revert nav text to abbreviation * GN-101 Code review fixes Co-authored-by: w@rren <[email protected]> * GN-102 Nitpicking css * GN-104 Rename var * GN-102 Pull url from services * GN-103 Use var for url * GN-98 Content update * demo stuff * GN-104 Url var * GN-102 Spacing * GN-103 Spacing * GN-105 Content for standards and indicators * GN-106 About us content * GN-105 Update links * GN-105 Remove standards and indicators from more * GN-101 Fix failing tests * GN-102 Update snapshot * GN-103 Update snapshot * GN-105 Update snapshot * GN-106 Update snapshot * GN-104 Update snapshot * GN-98 Snapshot updated * GN-000 Alpha services. May want renaming for UR. * GN-000 Renamed for UR. DO NOT DEPLOY TO LIVE. * GN-000 Snapshot updated * GN-000 Links for UR. DO NOT DEPLOY TO LIVE * GN-000 Prettier issue * GN-102 Fix letters and dancing button * GN-103 Button fix and letter link fix * GN-103 Button dancing fix * GN-103 Another dancing button fix attempt * GN-106 Content link issue * GN-105 Amend S&I base link * Start guidance content * AW/21 Colour Scheme * GN-98 Guidance content * GN-106 About us content update * GN-109 More content * GN-107 Pathways content * GN-108 Remove e.preventDefault on mega menu click handler to enable links to work * GN-108 Fix scrim * GN-108 Add canUseDOM state to control display of dropdown menus in main nav * Duplicate css removed * Remove duplicate CSS * Remove duplicate css * Remove duplicate export * Links to live * Tidy up * GN-108 Primary to CTA buttons * GN-108 Add column gap * GN-108 Consistent URLs Co-authored-by: Eleanor Mollett <[email protected]> Co-authored-by: John Davey <[email protected]> * GN-112 New simplified pathways content (#139) * GN-112 New simplified pathways content * GN-112 Remove pathways dropdown * GN-113 Alpha snag list (#140) * Settings * GN-113 Alpha snag list * Config typo * GN-000 Merge npm release (#144) * GN-116 Publishing to npm (#142) * GN-116 Pin Node version with Volta * GN-116 Update readme * GN-56 Footer logo and remove IE8 support for SVG fallback (#141) Co-authored-by: Ian Routledge <[email protected]> Co-authored-by: Ian Routledge <[email protected]> Co-authored-by: Ian Routledge <[email protected]> * GN-119 BNF CSS scoping (#146) * GN-138 Shorten nav copy (#147) * GN-140 Standards and indicators content (#151) * GN-116 Publishing to npm (#142) * GN-116 Pin Node version with Volta * GN-116 Update readme * GN-56 Footer logo and remove IE8 support for SVG fallback (#141) Co-authored-by: Ian Routledge <[email protected]> * GN-140 Standards removal Co-authored-by: Ian Routledge <[email protected]> Co-authored-by: Ian Routledge <[email protected]> * GN-118 Add non-JS dropdown (#149) * GN-118 Add non-JS dropdown * GN-118 More link fallback * Removed redundant nesting * GN-117 Remove need to assert on dom (#148) * context experiments * basic context setup * tidy up debugging * uncommen event listener for expected closing behaviour * make debug clearer * clean up console logging for clarity * move globalnavcontext provider up to header component * GN-117 add useCallback to clickOutside hook to maintain reference to id of open dropdown * GN-117 Refactor Nav component to class. Add custom hook and context for open dropdown state and nav area click outside detection * GN-117 Begin conversion of Account class component to functional component * GN-117 Remove commented out lines * GN-117 Reinstate propTypes for Naccount placeholder component * Side effect sideline (#150) * side effect shenanigans * Magical useRef() * update key event to use e.key rather than e.keycode for better cross platform * Move myAccount isExpanded state into GlobalNavContext * Remove redundant event binding * Make megamenu click detection more 'reacty' * Manage context of opened menus * Rename Naccount component to Account Co-authored-by: John Davey <[email protected]> * Tests needed * GN-117 Tidy up redundant arguments and commented out logic for useClickOutside hook * GN-117 Change directory structure for hooks and react context. Make useClickOutside re-useable. * GN-117 Import GlobalNavContextProvider from new location for Account tests * GN-117 Fixing broken unit tests * GN-117 Fixing broken tests * GN-117 Fixing broken tests * Replace simulate click * GN-117 Revert some tests to shallow rendering after adding defaults to context * GN-117 Revert to shallow mounting for a previously failing unit test * GN-117 Convert unit test from shallow to mount due to issues around enzyme support of useContext 'enzymejs/enzyme#2176' * GN-117 Rename GlobalNavContext to HeaderContext * GN-117 remove unused dependencies from account test * GN-117 Tidy up unit tests * testing custom hook useClickOutside * basic setup * Custom hook test * Update test * Rename test Co-authored-by: w@rren <[email protected]> * Set base high z-index (#152) * Snapshot update * Remove nerv * GN-146 Data tracking attributes * GN-146 Data tracking attributes (#153) * Update snapshot * GN-115 Add additional data-tracking attributes * GN-115 Update test snapshot * GN-145 Implement self contained grid system (#155) * Replace find with filter (#154) * GN-148 Fix content overflow * Move focus trap to deps * GN-149 Skip x route (#157) * GN-149 Reinstate ids for top level links to make them focussable upon closing dropdown * GN-149 Refactor Co-authored-by: w@rren <[email protected]> Co-authored-by: w@rren <[email protected]> * GN-130 Fix invisible white close button * Scrim flicker fix Co-authored-by: John Davey <[email protected]> * GN-115 Add IE11 compatible e.key string for escape key * GN-115 Fix bug in copy * GN-115 Add Esc to ESCAPE_KEYS for IE11 support * Communities link update * Fix concatenated links * Correct public involvement link (again) * GN-137 Add tests (#158) * Uncommented tests * GN-137 Add unit tests for dropdown component * Updated browserslist & caniuse * NavLinks test WIP * Trying to test WIP * GN-137 Fix tests for tracked link * GN-137 Update 'Proposed' to 'Awaiting development' * GN-137 Skip failing test - enzyme mocking hooks issue * GN-137 Fix or skip failing tests due to enzyme react hooks testing issues Co-authored-by: w@rren <[email protected]> * GN-154 Button styling Including GN-155 GN-153 * GN-115 Add data-tracking attrs for Standards and Indicators dropdown * Alpha current style override Co-authored-by: John Davey <[email protected]> Co-authored-by: Eleanor Mollett <[email protected]> Co-authored-by: John Davey <[email protected]> Co-authored-by: John Davey <[email protected]> Co-authored-by: Ian Routledge <[email protected]> Co-authored-by: Ian Routledge <[email protected]> Co-authored-by: John Davey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://nicedigital.atlassian.net/browse/GN-149