Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test cases for physical property access using mioDAQ #661

Conversation

SiuFong-NI
Copy link
Contributor

- [ ] I've updated CHANGELOG.md if applicable. Not applicable.

  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

I notice that there is no test case to test setting of physical property, this PR is trying to add new unit test case for that using mioDAQ. It was supposed to be added in #653, however the configurable digital voltage physical property is not supported in simulated device at that time. Now that the property is supported with simulated mioDAQ device, adding test via the property.

Why should this Pull Request be merged?

Increase test coverage.

What testing has been done?

Ran the test with a latest 25.0 DAQmx stack locally (the version that this configurable digital voltage feature is going to be released)
image
All other test still passed.
image

@SiuFong-NI
Copy link
Contributor Author

SiuFong-NI commented Dec 5, 2024

@zhindes @bkeryan The CI fails to run nidaqmxconfig.exe, did we cache this executable somewhere in the build machine and it requires an update? I try to run it with latest export from 25.0 and it runs successful.

image

@bkeryan
Copy link
Collaborator

bkeryan commented Dec 5, 2024

@zhindes @bkeryan The CI fails to run nidaqmxconfig.exe, did we cache this executable somewhere in the build machine and it requires an update? I try to run it with latest export from 25.0 and it runs successful.

image

Yes, you need to update the machine configuration to install DAQmx 25.x. Here's the PR from when it was updated to 24.5: https://dev.azure.com/ni/DevCentral/_git/ni-central/pullrequest/759606

If you need any more guidance on this, please follow up via MS Teams chat.

@SiuFong-NI SiuFong-NI requested a review from bkeryan December 11, 2024 02:20
@bkeryan
Copy link
Collaborator

bkeryan commented Dec 11, 2024

- [ ] I've updated CHANGELOG.md if applicable. Not applicable.

FYI: that's true, but you didn't update CHANGELOG.md for the previous change, so I updated it: #663

@bkeryan bkeryan merged commit d2e7efc into ni:master Dec 11, 2024
18 checks passed
@SiuFong-NI SiuFong-NI deleted the users/siutan/addUnitTestForMioDAQPhysicalChanProperty branch December 12, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants