-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up new metadata for mioDAQ configurable digital voltage feature #653
Pick up new metadata for mioDAQ configurable digital voltage feature #653
Conversation
Signed-off-by: Siu Fong Tan <[email protected]>
My first PR from github, just curious how do we complete a PR here? Do we have an auto-complete option? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's filter out the Power stuff since its not fully cooked. See Brad/my comments on the metadata PR.
My latest commit was to pull latest nidaqmx.proto from my grpc-device PR: ni/grpc-device#1115 |
Pending grpc-device-scrapigen https://github.com/ni/grpc-device-scrapigen/pull/251 to be merged before merging this PR. Looks like I do not have permission to complete the merge in this repo, @zhindes probably need your help later. Or probably someone can grant me a write access? |
@SiuFong-NI completed the PR for you |
Thanks @charitylxy for the help. Initially I was waiting for the https://github.com/ni/grpc-device-scrapigen/pull/251 to be merged first, I guess this change is independent so probably safe to merge first. |
What does this Pull Request accomplish?
Pickup new DAQmx metadata, updated attributes.py and enums.py.
Why should this Pull Request be merged?
To support configurable digital voltage feature for mioDAQ.
What testing has been done?
Ran
poetry run pytest
against 2 NI MAX configuration files specified in CONTRIBUTING.md.