-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional test for wait_for_valid_timestamp #510
Add functional test for wait_for_valid_timestamp #510
Conversation
I'm not quite sure how to test this, so I just went with no_error / expected error tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean the timestamp_val doesn't return anything? This is a simulated device, so I would at least expect a 0 timestamp...
@zhindes sorry I wasn't clear in the description. I meant it only returns AbsoluteTime 0. I have updated the comment |
Ah ok. Well that's the best we can do with simulated device. That being said, I suspect simulated devices always return that regardless of whether or not we waited for a timestamp. So, yeah, not very useful. I'm fine with what you have. |
83c7c85
to
af1690f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and fix the field_daq task name
7daa985
to
674cf83
Compare
What does this Pull Request accomplish?
Add unit test coverage for wait_for_valid_timestamp
What testing has been done?
Existing and newly added tests all pass