New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cancel API to Measurement Plug-In Client #870

Merged

Jotheeswaran-Nandagopal merged 16 commits into main from users/jothees/cancel-api

Sep 13, 2024

Contributor

Jotheeswaran-Nandagopal commented Sep 2, 2024

This contribution adheres to CONTRIBUTING.md.

What does this Pull Request accomplish?

Added Cancel API support to Measurement Plug-In Client.
Added Test cases for Cancel API.

Why should this Pull Request be merged?

Cancel API helps user to cancel the measure and stream-measure gRPC calls.

What testing has been done?

Tested manually.
Executed existing and new automated tests.

Jotheeswaran-Nandagopal requested review from csjall, dixonjoel, bkeryan, mshafer-NI and nstokes-nati as code owners

September 2, 2024 09:01

Jotheeswaran-Nandagopal requested a review from Avinash2Suresh

September 2, 2024 09:19

github-actions bot commented Sep 2, 2024 •

edited

Loading

Test Results

30 files ±0 30 suites ±0 38m 6s ⏱️ +23s
651 tests ±0 651 ✅ ±0 0 💤 ±0 0 ❌ ±0
16 130 runs ±0 15 060 ✅ ±0 1 070 💤 ±0 0 ❌ ±0

Results for commit dff0660. ± Comparison against base commit 6d75114.

♻️ This comment has been updated with latest results.

jayaseelan-james reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal requested a review from jayaseelan-james

September 2, 2024 15:01

jayaseelan-james requested changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal requested a review from jayaseelan-james

September 3, 2024 12:39

jayaseelan-james approved these changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

dixonjoel approved these changes

View reviewed changes

jayaseelan-james requested changes

View reviewed changes

Contributor

jayaseelan-james left a comment

The client module should be updated to handle measurements with no outputs.

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal requested a review from jayaseelan-james

September 4, 2024 10:29

jayaseelan-james requested changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal changed the title ~~Add Cancel API to Measurement Plug-In Client~~ [Internal] Add Cancel API to Measurement Plug-In Client

Jotheeswaran-Nandagopal requested a review from jayaseelan-james

September 6, 2024 09:01

Jotheeswaran-Nandagopal changed the title ~~[Internal] Add Cancel API to Measurement Plug-In Client~~ Add Cancel API to Measurement Plug-In Client

Jotheeswaran-Nandagopal force-pushed the users/jothees/cancel-api branch from 518236e to 4fb3b85 Compare

September 10, 2024 12:43

bkeryan requested changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal requested a review from bkeryan

September 11, 2024 13:37

Jotheeswaran-Nandagopal commented

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

jayaseelan-james reviewed

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

packages/generator/tests/acceptance/test_streaming_measurement_client.py Outdated Show resolved Hide resolved

Jotheeswaran-Nandagopal requested a review from jayaseelan-james

September 12, 2024 13:16

bkeryan approved these changes

View reviewed changes

Collaborator

bkeryan commented Sep 12, 2024

@jayaseelan-james Since you requested changes, you need to approve this before it can be merged.

Jotheeswaran-Nandagopal added 3 commits

September 13, 2024 09:17


          feat : add cancel API

115dc8b


          feat: add automated test

7292cfd


          doc: update comments

f3c8fc3

Jotheeswaran-Nandagopal added 12 commits

September 13, 2024 09:17


          fix: resolve comments

9de464e


          fix: update measure method in client

5a2dea6


          refactor: remove trailing whitespace

5f56f18


          fix: add support for None return type and implement threading locking

4f923db


          fix: resolve comments

fe50439


          fix: formatting

4be03b2


          fix: update threading

4023e12


          fix: resolve comments

91aef6d


          fix: remove unused imports

1a43ab7


          fix: resolve comments

e304eb0


          fix: update to raise error on cancellation

78cfdcc


          fix: resolve merge conflicts

86618c6

Jotheeswaran-Nandagopal force-pushed the users/jothees/cancel-api branch from da47a8b to 86618c6 Compare

September 13, 2024 04:01

Contributor Author

Jotheeswaran-Nandagopal commented Sep 13, 2024 •

edited

Loading

Updated the test assets and test cases, after rebasing with main.

jayaseelan-james approved these changes

View reviewed changes

...rator/ni_measurement_plugin_sdk_generator/client/templates/measurement_plugin_client.py.mako Outdated Show resolved Hide resolved

...st_assets/example_renders/measurement_plugin_client/non_streaming_data_measurement_client.py Outdated Show resolved Hide resolved


          fix: update documentation

dff0660

Jotheeswaran-Nandagopal merged commit e7251a3 into main

17 checks passed

Jotheeswaran-Nandagopal deleted the users/jothees/cancel-api branch

September 13, 2024 09:08

bkeryan mentioned this pull request

Intermittent test failure: test___streaming_measurement_execution___cancel___cancels_measurement #910

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jayaseelan-james jayaseelan-james approved these changes

dixonjoel dixonjoel approved these changes

bkeryan bkeryan approved these changes

csjall Awaiting requested review from csjall csjall is a code owner

mshafer-NI Awaiting requested review from mshafer-NI mshafer-NI is a code owner

nstokes-nati Awaiting requested review from nstokes-nati nstokes-nati is a code owner

Avinash2Suresh Awaiting requested review from Avinash2Suresh

Labels

None yet