Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance GetConnection(s) to Support Pins when Pin Groups are Reserved #636

Merged
merged 12 commits into from
Mar 6, 2024

Conversation

Avinash2Suresh
Copy link
Contributor

What does this Pull Request accomplish?

  • Update the _reserved_pin_or_relay_names to hold the flattened/resolved pin or relay names
  • Added automated tests.

Why should this Pull Request be merged?

  • AB#2643157: Obtain the connections for the reserved pins when the pin group is reserved.

What testing has been done?

Existing and new tests passes.

Copy link

github-actions bot commented Mar 4, 2024

Test Results

    25 files  ± 0      25 suites  ±0   31m 28s ⏱️ -41s
   627 tests + 5     627 ✅ + 5      0 💤 ±0  0 ❌ ±0 
12 445 runs  +45  11 385 ✅ +45  1 060 💤 ±0  0 ❌ ±0 

Results for commit 468da3d. ± Comparison against base commit 3b21763.

♻️ This comment has been updated with latest results.

@Avinash2Suresh
Copy link
Contributor Author

@bkeryan I'm awaiting your review to proceed with this PR. As this is a dependency PR for the upcoming change, please consider reviewing it at your earliest convenience.

@Avinash2Suresh Avinash2Suresh merged commit 64ec57a into main Mar 6, 2024
16 of 17 checks passed
@Avinash2Suresh Avinash2Suresh deleted the users/avinash/get-pin-conn branch March 6, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants