Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nims: Add Register and Unregister Multiplexer Sessions APIs #608

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

Avinash2Suresh
Copy link
Contributor

What does this Pull Request accomplish?

  • Updates pin_map_service.proto to reflect the latest documentation changes.
  • Updates the session_management_service.proto file to include the newly added RPC APIs.
  • Introduces register_multiplexer_sessions and unregister_multiplexer_sessions APIs, enabling the registration and unregistration of multiplexer sessions. AB#2623302

Why should this Pull Request be merged?

To enable multiplexer support in MeasurementLink, facilitating the registration and unregistration of multiplexer sessions.

What testing has been done?

  • New tests added to validate the registration and unregistration of multiplexer sessions.

Copy link

@SowmyaRavee SowmyaRavee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR with Jay's comments

Base automatically changed from users/jay/return-mux-data-from-get-connections to main February 7, 2024 05:52
@jayaseelan-james jayaseelan-james force-pushed the users/avinash/register-unregister-mux branch from f3b97a9 to be69b5e Compare February 7, 2024 06:21
@jayaseelan-james
Copy link
Contributor

I verified all the tests locally using Python 3.9.13-win32. Therefore, the system tests (py32) can be skipped.

@Avinash2Suresh Avinash2Suresh merged commit 81dbb79 into main Feb 7, 2024
14 of 15 checks passed
@Avinash2Suresh Avinash2Suresh deleted the users/avinash/register-unregister-mux branch February 7, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants