-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated from latest NI-DCPower exports #744
Updated from latest NI-DCPower exports #744
Conversation
@reckenro once your ni-central PR goes in, I'll pull together all the latest exports (dcpower and scope) and put them into an official PR for this. |
@astarche / @dmondrik , for the header and the metadata/proto I imported from 23.0.0d92 (latest export). But when doing the same for the nidcpower.lib file, I was getting linking errors for about six Those methods line up with some recent changes that went into DC Power in hapigen which will be resolved with this AzDo bug. So I took the most recent export whose nidcpower.lib worked with the other changes in this PR. That happened to be All that being said, is it okay to include an older nidcpower.lib file or should we wait for that Bug to be fixed and get a new nidcpower.lib from a future export? |
If an older import .lib file allows it to build correctly, then I think it's fine to proceed that way. There's no reason to block this arbitrarily. |
Windows system tests are currently busted because of issues with the grpcbot we run the tests on. It will be stuck in the queue forever. They pass locally and also run on Ubuntu as part of the |
What does this Pull Request accomplish?
nidcpower_grpc_device 23.0.0d114
nidcpower 23.0.0d114
nidcpower.lib
fromnidcpower 23.0.0d114
Breaking changes
ErrorQuery
: updated soErrorQueryRequest
doesn't haveerror_message
field but instead theErrorQueryResponse
has itExportAttributeConfigurationBuffer
andImportAttributeConfigurationBuffer
configuration
fields updated fromrepeated fixed64
tobytes
. This correction matches the header files and matches the similar function signatures innidmm.proto
andniscope.proto
.Why should this Pull Request be merged?
Covers the NI-DCPower part of the following task:
AB#2172471 : Import 23.0.x hapigen exports into grpc-device (nidcpower, niscope)
What testing has been done?
Built locally and NI-DCPower system tests still pass.