-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API errors now return information via gRPC metadata (not the response) #692
Conversation
… return a message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on CMakeLists changes and deferring to others on the code generation/API changes.
Looks like there's four integration tests (run as part of build_desktop part of CI) expecting errors that'll need to be updated to fit the new expectations:
I'm expecting a good bit of System tests to start failing too that expect and check errors (run after a successful build_desktop action is run). |
I'll be waiting for that now that I've fixed up the unit tests. |
What does this Pull Request accomplish?
API errors are now returned as part of gRPC metadata rather than as part of the response. This is more natural for gRPC.
Why should this Pull Request be merged?
Task 2103382: Change generated code to return UNKNOWN on error status.
What testing has been done?
I built locally. I have not run any tests manually but I am expecting they will run as part of this PR.