Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new executable flag to check if main or release version #1038

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

christag-ni
Copy link
Contributor

What does this Pull Request accomplish?

This PR adds new command line functionality by allowing clients to see if their executable version is from a main or release branch.

Why should this Pull Request be merged?

To be able to easily determine if clients' version of ni_grpc_device_server is from a main or release branch

What testing has been done?

When the branch is from main (name doesn't begin with 'releases')
image

When it is a release version (begins with 'releases')
image

Closes #828

@christag-ni
Copy link
Contributor Author

@bkeryan The validate_python step failed here for not having black locked to 23.3.0.
https://github.com/ni/grpc-device/actions/runs/7731440933/job/21237217346?pr=1038#:~:text=Using%20version%20%5E24.1.1,45

From the other PR I completed to resolve this issue, that line of highlighted text doesn't appear, making me assume that PR used 23.3.0. Even though that PR is merged, does it take a while for new PR's to use the proper version?

@reckenro
Copy link
Collaborator

reckenro commented Feb 5, 2024

@bkeryan The validate_python step failed here for not having black locked to 23.3.0. https://github.com/ni/grpc-device/actions/runs/7731440933/job/21237217346?pr=1038#:~:text=Using%20version%20%5E24.1.1,45

From the other PR I completed to resolve this issue, that line of highlighted text doesn't appear, making me assume that PR used 23.3.0. Even though that PR is merged, does it take a while for new PR's to use the proper version?

Oh, I'm pretty sure the GitHub actions just run off the code in the PR branch. So you'll have to merge main into this branch and push up to get the PR build to pass I think.

Unlike how we have AzDo set up where I think it'll merge the PR branch with main before running any of the checks. We might've considered doing that for this repo at some point (I can't recall) but it was never high enough value to investigate.

@christag-ni christag-ni requested a review from reckenro February 13, 2024 23:55
@christag-ni
Copy link
Contributor Author

@astarche @maxxboehme @reckenro Could y'all please approve this PR if there are no further changes?

@christag-ni christag-ni merged commit 461ab76 into main Feb 14, 2024
11 checks passed
@christag-ni christag-ni deleted the users/christag-ni/noteDevWithCommand branch February 14, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distinguish Windows executable version in main.
3 participants