Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header container responds differently to width container #901

Closed
paulrobertlloyd opened this issue Nov 8, 2023 · 0 comments
Closed

Header container responds differently to width container #901

paulrobertlloyd opened this issue Nov 8, 2023 · 0 comments

Comments

@paulrobertlloyd
Copy link
Contributor

paulrobertlloyd commented Nov 8, 2023

Bug Report

.nhsuk-header__container introduces different inline margin sizes at different breakpoints from that of .nhsuk-width-container. This means that at certain breakpoints, elements in the header don’t align with other elements on the page.

What is the issue?

Here are a few snapshots taken at different viewport widths

  • Up to 640px, the containers share the same inline margin size (16px):

    NHS header on 640px wide screen.
  • Between 641px and 768px, the header container has an inline margin of 32px while the width container sticks with 16px:

    NHS header on 768px wide screen.
  • Between 769px and 989px, the contains again share the same inline margin size (32px):

    NHS header on 800px wide screen.
  • Above 990px, the header container uses an inline margin of auto while the width container remains sticks with 32px:

    NHS header on 990px wide screen.
  • Above 1024px, max-widths kick in and the containers are aligned again.

What was the environment where this issue occurred?

  • Device: Mac
  • Operating System: macOS Sonoma
  • Browser: Safari
  • Browser version: 17.1
  • NHS.UK frontend package version: 8.0.2
@paulrobertlloyd paulrobertlloyd changed the title Header container responds differently from width container Header container responds differently to width container Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants