Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue: LICENSE #32

Closed
rrrlw opened this issue Dec 20, 2021 · 2 comments
Closed

Minor issue: LICENSE #32

rrrlw opened this issue Dec 20, 2021 · 2 comments

Comments

@rrrlw
Copy link

rrrlw commented Dec 20, 2021

The MIT license is appropriate. However, you need a copy of the plaintext license (https://opensource.org/licenses/MIT) in the repository per JOSS guidelines.

Part of this JOSS review.

@rrrlw
Copy link
Author

rrrlw commented Dec 20, 2021

I now see the MIT license in the README - moving it to the LICENSE file or a new LICENSE.md file should be sufficient.

@nhejazi
Copy link
Owner

nhejazi commented Dec 20, 2021

Thanks for pointing this out, I'd neglected to include a LICENSE.md file but agree that it's a good practice. This has been addressed in b990c07 of #34.

@nhejazi nhejazi closed this as completed Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants