Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: default value on linkedQueryParam #541

Open
eneajaho opened this issue Jan 16, 2025 · 0 comments
Open

bug: default value on linkedQueryParam #541

eneajaho opened this issue Jan 16, 2025 · 0 comments
Assignees

Comments

@eneajaho
Copy link
Collaborator

Should we always set the defaultValue on linkedQueryParam or only when the change comes from the query params.

Currently:

aParam = linkedQueryParam('a', { defaultValue: 1 });

When a queryParam changes to null or undefined the value of aParam will be set to 1
When we set the value of aParam to null (aParam.set(null)), the value will be null.

The question is: should we always fallback to defaultValue, or only when queryParam changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant