Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SignalSlice Type doesn't match the return object. #520

Closed
LukeEdgecock-Bennett opened this issue Nov 2, 2024 · 1 comment · Fixed by #521
Closed

SignalSlice Type doesn't match the return object. #520

LukeEdgecock-Bennett opened this issue Nov 2, 2024 · 1 comment · Fixed by #521

Comments

@LukeEdgecock-Bennett
Copy link

can we please add InitialStateStreams to the type definition for SignalSlice?

I spent a while trying to figure out why I couldn't see the initial values streams on my state object until I realised that it was missing from the type definition.

@joshuamorony is it intended to be missing at the current stage?
@joshuamorony joshuamorony mentioned this issue Nov 4, 2024
Merged
@joshuamorony
Copy link
Contributor

Thanks @LukeEdgecock-Bennett I've put up a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(signal-slice): add initial state stream typing to state object joshuamorony/ngxtension-platform
2 participants
@joshuamorony @LukeEdgecock-Bennett